Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix calculation of geomean in TPROC-H #504

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

igorkonopko
Copy link
Contributor

Query 15 in TPROC-H is a multi-statement query, which consists of two parts: creating the view and querying that view. Due to that it is handled using separate code then all the other queries. Currently, the execution time of query 15 is not calculated as a part of geometric mean value, which is the metric for that test.

This patch fixes that to include query execution time in geometric mean metric. Creating/dropping the view is still not taken into that calculation, so no changes here.

Signed-off-by: Igor Konopko igor.j.konopko@intel.com

Signed-off-by: Igor Konopko <igor.j.konopko@intel.com>
Copy link
Contributor

@sm-shaw sm-shaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested the change on both mariadb columnstore and innodb and they both work as intended.

@abondvt89 abondvt89 merged commit cac3337 into TPC-Council:master Feb 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants