Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding sample scripts to HammerDB home directory #509

Merged
merged 1 commit into from
Feb 9, 2023
Merged

Adding sample scripts to HammerDB home directory #509

merged 1 commit into from
Feb 9, 2023

Conversation

pooja-jain-17
Copy link
Collaborator

Added the sample scripts directory to home folder of HammerDB as described in Issue #508

Will delete scripts in Docker folder when we update the Dockerfile to version 4.7 in subsequent updates.
Doing so now will break the auto-builds and docker images. Thanks.

@pooja-jain-17 pooja-jain-17 requested a review from a team as a code owner February 7, 2023 19:53
sm-shaw
sm-shaw requested changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@sm-shaw sm-shaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. We should also remove them from the Docker folder as well at the same time with another commit to this PR, so we don't have the same scripts in 2 different locations, as they could then diverge over time.

@sm-shaw sm-shaw linked an issue Feb 8, 2023 that may be closed by this pull request
Include the sample scripts as part of HammerDB Distribution package #508
Closed
@sm-shaw
Copy link
Contributor

sm-shaw commented Feb 8, 2023

Please ignore initial review, I re-read

Will delete scripts in Docker folder when we update the Dockerfile to version 4.7 in subsequent updates.
Doing so now will break the auto-builds and docker images. Thanks.

So yes, this is fine as is and we can delete the ones in the Docker folder with a future PR

memmertoIBM
memmertoIBM approved these changes Feb 8, 2023
View reviewed changes
Copy link
Contributor

@memmertoIBM memmertoIBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving on the strength of Steve's review.

@abondvt89 abondvt89 merged commit 6376359 into TPC-Council:master Feb 9, 2023
@pooja-jain-17 pooja-jain-17 mentioned this pull request Mar 14, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abondvt89 abondvt89 abondvt89 approved these changes

@sm-shaw sm-shaw sm-shaw approved these changes

@memmertoIBM memmertoIBM memmertoIBM approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Include the sample scripts as part of HammerDB Distribution package
4 participants
@pooja-jain-17 @sm-shaw @abondvt89 @memmertoIBM