-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Use bcp as a user option #587
Conversation
I have tested and made some additional changes to the pull request with this commit bcp option updates and fix
I assume that is because you need to use SQL Authentication and not Windows authentication for this feature? So I have updated the GUI options so that the BCP option it is greyed out (and unselected if selected) if Windows authentication is selected. I have also set the default option to false in the XML assuming that not everyone with have SQL authentication enabled by default. Therefore anyone using hammerdb for the first time will use the slower way but it is likely to work out-of-the-box.
I've tested (on what is now a relatively slow PC) and the build time with the BCP option is at least 2X so the functionality does what is intended.
I have also checked the consistency and the schema looks as it should and also tested performance after the build compared to the original and the performance looks the same, so approving the PR from my side. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tested and added some changes with bcp option updates and fix and approved.
Merging after reviews and approval of the three members of the code maintenance team. |
Added user option that enables bulk copy program (bcp) utility to speed data table insertion. This replaces the existing implementation of SQL "insert into" statements. Created additional methods for Customer, Orders and Stock tables that use bcp (bulk copy program) to load data into tables as to not interfere with existing implementation.