Added use_bcp default as true and enabled bcp with windows authentication #592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamiere-msft
approved these changes
Sep 8, 2023
sm-shaw
approved these changes
Sep 11, 2023
There was a problem hiding this comment.
On testing, virtual users would error with following message:
Error in Virtual User 2: Error: can't read "authentication": no such variable
This is because it checks the value of the authentication variable but this variable is not set in this proc. Added upvar so that the authentication variable setting can be queried without error.
With fix test shows that bcp load works with Windows authentication meaning the option can be the default as it is faster.
|
Tested on all combinations of Windows and SQL authentication with and without BCP selected |
This was referenced Sep 11, 2023
abondvt89
approved these changes
Sep 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The use_bcp option was by default set to false because bcp did not work through windows authentication. Bcp statement is now modified based on authentication type, with the -T flag used in place of a specified username and password when the connection is through windows authentication. This ensures that the bcp command will use the Windows logged in user's credentials.