Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for TPROC-H calculates o_totalprice incorrectly #610

Merged
merged 13 commits into from
Oct 3, 2023

Conversation

sm-shaw
Copy link
Contributor

@sm-shaw sm-shaw commented Oct 2, 2023

Fixes o_totalprice calculation for all databases for TPROC-H schema load.

Also does the same for refresh function, which is defined as follows:

LOOP (SF * 1500) TIMES
INSERT a new row into the ORDERS table
LOOP RANDOM(1, 7) TIMES
INSERT a new row into the LINEITEM table
END LOOP
END LOOP

However, o_totalprice is calculated from the sum of the rows in LINEITEM and therefore we need to insert it after LINEITEM otherwise o_totalprice is 0 (current behaviour) This in turn causes the issue that we have a foreign key on LINEITEM L_ORDERKEY referencing ORDERS O_ORDERKEY, so we cannot insert in ORDERS before as we don't know o_totalprice and cannot insert after as it violates the FK.
Therefore, have added deferrable constraints for Oracle and PostgreSQL and temporary disabling of FK checks for SQL Server, MySQL/MariaDB and Db2 so that the refresh function will work by inserting into LINEITEM first.

@sm-shaw sm-shaw requested a review from a team as a code owner October 2, 2023 14:08
@sm-shaw sm-shaw linked an issue Oct 2, 2023 that may be closed by this pull request
@sm-shaw sm-shaw added the bug Something isn't working label Oct 2, 2023
JoshInnis pushed a commit to JoshInnis/HammerDB that referenced this pull request Oct 2, 2023
Update the total price logic for BCP to be in line with the PR
TPC-Council#610.
@abondvt89
Copy link
Contributor

Merging after reviews and approval of the three members of the code maintenance team.

@abondvt89 abondvt89 merged commit 42c8026 into TPC-Council:master Oct 3, 2023
sm-shaw added a commit that referenced this pull request Oct 3, 2023
* Implement BCP Option for MSSQLS TPCH Load

Allow users to use the BCP option to load data for TPCH data. The
option is enabled by default, becuase BCP will work for both SQL and
Windows Authentication.

* Add mk_time_bcp to export list

Added mk_time_bcp in export list for tpchcommon to be used in mssqls' TPCH load process when BCP is enabled

* Update total price for BCP Load of TPCH

Update the total price logic for BCP to be in line with the PR
#610.

* Add XML variable and updates to TPCH BCP

* Fix XML spacing

---------

Co-authored-by: Josh Innis (Warner Marketing Incorporated) <v-joshinnis@microsoft.com>
Co-authored-by: Steve Shaw <smshaw@users.sourceforge.net>
Co-authored-by: Steve Shaw <38044085+sm-shaw@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TPROC-H o_totalprice calculated incorrectly
3 participants