Test QMCkl with the latest TREXIO + MacOS CI #58
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is required to make `test_qmckl_trexio` pass with the recent additions to the TREXIO (see `unsafe` attribute of the metadata group).
scemama
approved these changes
Feb 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
test_qmckl_trexiowas failing with recent versions of TREXIO due to the modifications in themetadatagroup which made the TREXIO file inshare/qmckl/test_data/chbrclfincompatible (see TREXIO issue #81).This PR fixes this by:
metadatagroup in theshare/qmckl/test_data/chbrclfIn the meantime, I also enabled the GitHub CI for MacOS.
Note: I removed rather useless
AC_PROG_F77check fromconfigure.acwhich requires thef77or some other default Fortran 77 compiler name. I do not see the point of checking this since QMCkl at present does not have Fortran 77 code.