-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP - Cyclefeatures #568
Draft
pasinger
wants to merge
16
commits into
TRI-AMDD:master
Choose a base branch
from
pasinger:cyclefeatures
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
WIP - Cyclefeatures #568
Commits on Mar 17, 2022
-
add class BEEPCycleFeatureMatrix to combine features which were generated at every diagnostic cycle
Configuration menu - View commit details
-
Copy full SHA for 0d37321 - Browse repository at this point
Copy the full SHA 0d37321View commit details -
Add CycleFeatures classes and change existing class names to EarlyFeatures where appropriate. HPPCResistanceVoltageCycleFeatures returns hppc resistance features at every diagnostic. DiagnosticCycleFeatures returns some standard quantities, like discharge capacity of various RPTs across all diagnostic cycles. CyclingProtocol returns cycling protocol information for the cell. This was integrated from the ChargingProtocol class written by Amalie Trewartha.
Configuration menu - View commit details
-
Copy full SHA for 6bf62f9 - Browse repository at this point
Copy the full SHA 6bf62f9View commit details -
Update DEFAULT_HYPERPARAMETERS and dependent calls to match updates to intracell_analysis.py. Modify some variable names for easier understanding and consistency across files (e.g. using "diag_pos" in for loop instead of "i"). Update dataframe construction to match updates in intracell_analysis.py.
Configuration menu - View commit details
-
Copy full SHA for 48f0c0f - Browse repository at this point
Copy the full SHA 48f0c0fView commit details -
Update intracell_analysis_v2.py
Modify reference electrode data to be a dictionary of rates and rate file names, instead of file names for one rate; these changes are necessary for other updates which seek to correct for effective rate in the electrodes and utilize multiple rate data of the electrodes. Incorporate changes for using alternative error metrics, such as dVdQ instead of the V-Q curve.
Configuration menu - View commit details
-
Copy full SHA for e4c463c - Browse repository at this point
Copy the full SHA e4c463cView commit details
Commits on Mar 18, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 7d4d2dc - Browse repository at this point
Copy the full SHA 7d4d2dcView commit details
Commits on Mar 29, 2022
-
Configuration menu - View commit details
-
Copy full SHA for e85dd0e - Browse repository at this point
Copy the full SHA e85dd0eView commit details
Commits on Mar 30, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 01294eb - Browse repository at this point
Copy the full SHA 01294ebView commit details -
Configuration menu - View commit details
-
Copy full SHA for f5780c8 - Browse repository at this point
Copy the full SHA f5780c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0778f9 - Browse repository at this point
Copy the full SHA f0778f9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e7a3ce - Browse repository at this point
Copy the full SHA 1e7a3ceView commit details -
Configuration menu - View commit details
-
Copy full SHA for 2f19177 - Browse repository at this point
Copy the full SHA 2f19177View commit details -
Configuration menu - View commit details
-
Copy full SHA for d8781b5 - Browse repository at this point
Copy the full SHA d8781b5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33af986 - Browse repository at this point
Copy the full SHA 33af986View commit details -
Configuration menu - View commit details
-
Copy full SHA for baab63b - Browse repository at this point
Copy the full SHA baab63bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3dd9da5 - Browse repository at this point
Copy the full SHA 3dd9da5View commit details -
Configuration menu - View commit details
-
Copy full SHA for d07c2ab - Browse repository at this point
Copy the full SHA d07c2abView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.