Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Break data display out into dedicated popover #61

Merged
merged 5 commits into from
Sep 4, 2019
Merged

Break data display out into dedicated popover #61

merged 5 commits into from
Sep 4, 2019

Conversation

sgratzl
Copy link
Contributor

@sgratzl sgratzl commented Sep 4, 2019

first version of a simple popper window instead of showing on the left

Screenshot from 2019-09-04 09-17-03

@sgratzl sgratzl requested a review from waxlamp September 4, 2019 13:19
@sgratzl sgratzl mentioned this pull request Sep 4, 2019
Closed
@waxlamp waxlamp changed the title Sgratzl/popover Break data display out into dedicated popover Sep 4, 2019
waxlamp
waxlamp approved these changes Sep 4, 2019
View reviewed changes
Copy link
Collaborator

@waxlamp waxlamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks!

@sgratzl sgratzl self-assigned this Sep 4, 2019
@sgratzl sgratzl merged commit b177775 into geojs Sep 4, 2019
@sgratzl sgratzl deleted the sgratzl/popover branch September 4, 2019 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waxlamp waxlamp waxlamp approved these changes

Assignees

@sgratzl sgratzl

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sgratzl @waxlamp