Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix conversion in key point and keyline 3d #167

Merged
merged 3 commits into from
Aug 6, 2024

Conversation

chrisochoatri
Copy link
Collaborator

@chrisochoatri chrisochoatri commented Aug 1, 2024

Keypoint and keyline 3d were being converted to integers on saving, the proto definition expects floats. This leads to loss of precision on saving.


This change is Reviewable

@chrisochoatri chrisochoatri changed the title fix: fix conversion in key point 3d fix: fix conversion in key point and keyline 3d Aug 1, 2024
Copy link
Contributor

@nehalmamgain nehalmamgain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch, thanks Chris!

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: 0 of 2 files reviewed, all discussions resolved

Copy link
Collaborator Author

@chrisochoatri chrisochoatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r3.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @chrisochoatri)

Copy link
Collaborator Author

@chrisochoatri chrisochoatri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, 1 of 1 files at r2.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @chrisochoatri)

Copy link
Contributor

@nehalmamgain nehalmamgain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @chrisochoatri)

@chrisochoatri chrisochoatri merged commit f70196d into TRI-ML:master Aug 6, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants