Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pyupgrade to pre-commit and upgrade to future-style type annotations #89

Merged
merged 4 commits into from Mar 4, 2022

Conversation

TRoboto
Copy link
Owner

@TRoboto TRoboto commented Mar 3, 2022

What does this pull request change?

Upgrades to new type annotations style.

Status (please check what you already did):

  • added some tests for the functionality
  • updated the documentation
  • tox passes

@codecov
Copy link

codecov bot commented Mar 3, 2022

Codecov Report

Merging #89 (8b2ac19) into main (666b585) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #89   +/-   ##
=======================================
  Coverage   96.93%   96.94%           
=======================================
  Files          64       64           
  Lines        2281     2288    +7     
=======================================
+ Hits         2211     2218    +7     
  Misses         70       70           
Impacted Files Coverage Δ
maha/expressions/general.py 100.00% <ø> (ø)
maha/cleaners/functions/contains_fn.py 100.00% <100.00%> (ø)
maha/cleaners/functions/keep_fn.py 100.00% <100.00%> (ø)
maha/cleaners/functions/normalize_fn.py 100.00% <100.00%> (ø)
maha/cleaners/functions/remove_fn.py 100.00% <100.00%> (ø)
maha/cleaners/functions/replace_fn.py 100.00% <100.00%> (ø)
maha/constants/arabic/compound.py 100.00% <100.00%> (ø)
maha/constants/english/compound.py 100.00% <100.00%> (ø)
maha/constants/general.py 100.00% <100.00%> (ø)
maha/constants/persian/compound.py 100.00% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 666b585...8b2ac19. Read the comment docs.

@TRoboto TRoboto added the maintenance refactoring, typos, and other code quality improvements label Mar 3, 2022
@lgtm-com
Copy link

lgtm-com bot commented Mar 3, 2022

This pull request fixes 3 alerts when merging 608290b into 981e627 - view on LGTM.com

fixed alerts:

  • 3 for Unused import

@lgtm-com
Copy link

lgtm-com bot commented Mar 4, 2022

This pull request fixes 3 alerts when merging 8b2ac19 into 666b585 - view on LGTM.com

fixed alerts:

  • 3 for Unused import

@TRoboto TRoboto merged commit f6bb526 into main Mar 4, 2022
@TRoboto TRoboto deleted the upgrade-code branch March 4, 2022 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance refactoring, typos, and other code quality improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant