Moved Fire and Radius Damage to Game Effects Library #1318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TimGoll
requested changes
Jan 24, 2024
TimGoll
changed the title
TimGoll
added
type/enhancement
yeah, i was looking more at separating this from the other messy changes and overlooked these from the 2 month old code |
TimGoll
approved these changes
Jan 24, 2024
EntranceJew
force-pushed
the
feature/fire-not-be-shitty-challenge
branch
5 times, most recently
from
f573af7
to
d64e7a9
Compare
saibotk
requested changes
Feb 3, 2024
EntranceJew
force-pushed
the
feature/fire-not-be-shitty-challenge
branch
from
9e9f291
to
81eb2bc
Compare
saibotk
requested changes
Feb 4, 2024
Co-authored-by: Tim Goll <github@timgoll.de>
EntranceJew
force-pushed
the
feature/fire-not-be-shitty-challenge
branch
from
60b60ed
to
b92af77
Compare
saibotk
approved these changes
Feb 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
because it looks good instead of bad