Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable locational voice during the preparing phase by default #1490

Merged
merged 3 commits into from
Mar 31, 2024

Conversation

ruby0b
Copy link
Contributor

@ruby0b ruby0b commented Mar 29, 2024

(didn't get a chance to test this with someone else yet so I'm setting it as a draft, should work though)

CHANGELOG.md Outdated Show resolved Hide resolved
gamemodes/terrortown/gamemode/server/sv_voice.lua Outdated Show resolved Hide resolved
@TimGoll TimGoll added this to the v0.14.0b milestone Mar 30, 2024
@TimGoll TimGoll added the type/enhancement Enhancement or simple change to existing functionality label Mar 30, 2024
ruby0b and others added 2 commits March 30, 2024 16:38
Copy link
Member

@Histalek Histalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

refactoring the locational voice conditions into a local function is a really nice change!

@TimGoll
Copy link
Member

TimGoll commented Mar 30, 2024

I will approve it as soon as you tested it

@ruby0b ruby0b marked this pull request as ready for review March 31, 2024 13:12
@ruby0b
Copy link
Contributor Author

ruby0b commented Mar 31, 2024

tested, works

@TimGoll TimGoll merged commit 11de20d into TTT-2:master Mar 31, 2024
5 checks passed
@ruby0b ruby0b deleted the locational_voice_prep branch April 6, 2024 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement Enhancement or simple change to existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants