Add multiple voice chat activation modes

[ruby0b]

• Push-to-Talk (default)
• Push-to-Mute
• Toggle
• Toggle (Activate on Join)

Things left to do that should probably be new PRs:

• Investigate how keeping voice chat activated interacts with rounds starting/ending
  • The voice chat color should update accordingly. HUD-related changes should probably wait for Voice: Reworked HUD #1473 though
  • I think voice chat might currently get disabled once on round start (but your voice panel keeps being shown)
• Improve how team voice chat interacts with modes other than push-to-talk
  • I didn't touch the TeamVoice functions which means that currently team voice can only be activated while global voice is off which is obviously silly for PTM/Toggle
• (Maybe have separate sections (forms) for input and output settings in the Voice & Volume menu)
• (Move ComboBoxChoicesFromKeys somewhere else since it's just a form creation utility function)

[TimGoll]

The voice chat color should update accordingly. HUD-related changes should probably wait for #1473 though

Right now the voice color is only set once. I could change this in the linked PR though. So it sets a mode (team or global) and the color is set each frame

Improve how team voice chat interacts with modes other than push-to-talk

I'm fine with this being done in a secondary PR. But in general I'm a bit confused. Is this a draft PR? Or are these todos things that should be done in further PRs? Because you say "Things left to do that should probably be new PRs" but also have todos in code, which should be removed

[ruby0b]

I've removed the todo and made the affected utility function local. To clarify, this is not a draft, I just wrote down what interactions with existing code I'd want to change as well (didn't want to do all of that here to prevent merge conflicts).

Regarding voice color, my intuition would've been to somehow hook into role assignment/changing and modify the color then but if updating the color every frame isn't a big deal performance-wise than that's probably a way simpler solution.

[TimGoll]

Regarding voice color, my intuition would've been to somehow hook into role assignment/changing and modify the color then but if updating the color every frame isn't a big deal performance-wise than that's probably a way simpler solution.

All UI elements read the color on a frame by frame basis, so this is fine

[saibotk]

Only a small nit, otherwise very very good!

Thanks for the amazing PR and clean code, that was really nice to review!

[TimGoll]

LGTM. Just a note for the future: Please do not resolve the conversations yourself. We - as the reviewer - close them to keep track of it.

[saibotk]

Nice thank you very much 👍