Fixed a regression caused by a641a21fa146542585e15e3ea3a7f133bee31c8d that makes a long, top aligned label sometimes not draw the last line #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The bug can be triggered by having the alignment being TTTAttributedLabelVerticalAlignmentTop and lineHeightMultiple being greater than 1 (1.03, for example). Matt's old code handled this well, but a641a21 broke it.
|
Sorry for the regression. I tried this out and it seems to fix things like you said. Merging this in now. Thanks! |
mattt
added a commit
that referenced
this pull request
Jun 26, 2012
Fixed a regression caused by a641a21 that makes a long, top aligned label sometimes not draw the last line
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The bug can be triggered by having the alignment being
TTTAttributedLabelVerticalAlignmentTop and lineHeightMultiple being
greater than 1 (1.03, for example). Matt's old code handled this well,
but a641a21 broke it.