Added vertical text centering, added shadow property per issue #10 #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t take up the full label size (mirroring the functionality of UILabel)
mattt
pushed a commit
that referenced
this pull request
Aug 25, 2011
Added vertical text centering, added shadow property per issue #10
|
Wow, fantastic work, Mark. I'm seriously impressed how much you added with your pull request. That's enough to warrant another release, I'd say :) Also, great job commenting through the bulk of the drawTextInRect method. That was a quite the beast before, but makes a complete sense with your notes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed drawTextInRect: method to vertically center text that does not take up the full label size (mirroring the functionality of UILabel)
Also added the shadow capability -- extracted the drawing method to a helper since it's called twice with the exact same lines of code.