Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ITMS-90809: Deprecated API Usage (UIWebView) #812

Merged
merged 1 commit into from Aug 11, 2020

Conversation

svetlanama
Copy link
Contributor

No description provided.

Copy link

@rorybeling rorybeling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apple picking this up as an issue and blocking builds.

@jzeferino
Copy link

@segiddins can you please take a look at this. this is very important.

@segiddins
Copy link
Member

All this PR is doing is changing a comment, I don’t think it’s addressing the underlying API usage that iTunes Connect is complaining about

@jzeferino
Copy link

@segiddins I know its weird but for a lot of people apps are being rejected due to this library, and the only reference to UIWebView is in the comments so I'm assuming Apple is looking at the source of this library and searching for UIWebView.
Do you mind to do that release so we can test if this is the issue?

@segiddins
Copy link
Member

Has someone submitted with this patch applied and confirmed it fixes the issue?

@Gabriel-Azevedo
Copy link

@segiddins I just submitted to Testflight pointing to the svetlanama:issue-810 branch and it worked.

@svetlanama
Copy link
Contributor Author

@segiddins I just submitted to Testflight pointing to the svetlanama:issue-810 branch and it worked.

It helped to me also
I use grep to check all things before uploading to AppStore

cd app
grep -r "UIWebView" .
./Pods/TTTAttributedLabel/TTTAttributedLabel/TTTAttributedLabel.h: to emulate the link detection behaviour of UIWebView.

After applying changes svetlanama:issue-810 it was gone.
The processing of the build was completed successful without issues.

@segiddins segiddins merged commit e73ed54 into TTTAttributedLabel:master Aug 11, 2020
@jzeferino
Copy link

@segiddins when you plan to release this?

@Kaloian92
Copy link

Same question as jzeferino, when do you plan do release this, because all of the apps that are using "TTTAttributedLabel" should use this fix, if they want to release their app in the AppStore?

@Kaloian92
Copy link

Hi again, sorry for the spam, but we still need to know if you are planing to release this or not, as it is now mandatory for any project that use "TTTAttributedLabel", to use svetlanama's fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet