Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Core: Added SettingsSystem #189

Merged
merged 8 commits into from
Aug 15, 2021
Merged

Core: Added SettingsSystem #189

merged 8 commits into from
Aug 15, 2021

Conversation

Alf21
Copy link
Member

@Alf21 Alf21 commented Aug 14, 2021

s-box-2021-08-15-02-00-19_xvnYflst.mp4

Added language and sprint to settings (saved).

TODO:

  • Option to save current settings
  • Option to load custom settings (hint whether old settings should be saved as well, otherwise they're getting overwritten)

@Alf21 Alf21 added area/code Something regarding the codebase issue/feature-request This issue is a feature request labels Aug 14, 2021
@Alf21 Alf21 requested a review from matekdev August 14, 2021 18:12
@Alf21 Alf21 self-assigned this Aug 14, 2021
@Alf21 Alf21 linked an issue Aug 15, 2021 that may be closed by this pull request
6 tasks
@Alf21 Alf21 marked this pull request as ready for review August 15, 2021 00:28
Copy link
Contributor

@matekdev matekdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alf21 Alf21 mentioned this pull request Aug 15, 2021
@Alf21 Alf21 merged commit 89fe728 into master Aug 15, 2021
@Alf21 Alf21 deleted the settings branch August 15, 2021 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/code Something regarding the codebase issue/feature-request This issue is a feature request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

SettingsSystem
2 participants