Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New caching solution #27

Closed
meffmadd opened this issue Jan 29, 2024 · 0 comments
Closed

New caching solution #27

meffmadd opened this issue Jan 29, 2024 · 0 comments
Assignees
@mpetojevic
Labels
enhancement New feature or request frontend needs-triage
Milestone
0.4.1

Comments

@meffmadd
Copy link
Member

Is your feature request related to a problem? Please describe.
Our caching and data loading solution is very limited and correctly updating data is difficult (e.g. see #1).

Describe the solution you'd like
Open for discussion... Possible solutions are SWR or Tanstack Query. The problem with these approaches is that they are integrated into React and e.g. the cache could not easily be invalidated in the service functions.
@meffmadd meffmadd mentioned this issue Jan 29, 2024
Closed
mpetojevic added a commit that referenced this issue Mar 18, 2024
@mpetojevic
Added React Query to Asignment Status -> this completes fetching assi…
2e642e0 
…gnment data for the whole overview window.

ref: #27
mpetojevic added a commit that referenced this issue Mar 18, 2024
@mpetojevic
Use ReactQuery for creating new Submission in grading view.
9200e1b 
ref: #27
mpetojevic added a commit that referenced this issue Mar 21, 2024
@mpetojevic
Feat: Use react query for fetching files into the FilesList
a960782 
Ref: #27
mpetojevic added a commit that referenced this issue Apr 4, 2024
@mpetojevic
Feat: Use react query for creating submission directories in "create …
1703fd6 
…submission".

ref: #27
mpetojevic added a commit that referenced this issue Apr 4, 2024
@mpetojevic
Feat: Use React Query for (re)loading submission and submission logs …
5af3963 
…in edit submission view.

Ref: #27
@florian-jaeger florian-jaeger added this to the 0.4.1 milestone Apr 8, 2024
mpetojevic added a commit that referenced this issue Apr 15, 2024
@mpetojevic
feat: Incoporated use of ReactQuery in grading table.
8dfb910 
Ref: #27
mpetojevic added a commit that referenced this issue Apr 17, 2024
@mpetojevic
Fix: Load right submission scaling when navigating through submissions.
b03c9f8 
Problem was: when navigating through submissions with forward and back button, the loaded submission scaling
shown was always the same (didn't reload with the submission). Fixed that.

Ref: #27
mpetojevic added a commit that referenced this issue Apr 17, 2024
@mpetojevic
Feat: Use React Query in manual submission view for managing states.
1bd5a88 
Ref: #27
mpetojevic added a commit that referenced this issue Apr 17, 2024
@mpetojevic
Fix: Load right submission scaling when navigating through submissions.
cb3ca77 
Problem was: when navigating through submissions with forward and back button, the loaded submission scaling
shown was always the same (didn't reload with the submission). Fixed that.

Ref: #27
mpetojevic added a commit that referenced this issue Apr 17, 2024
@mpetojevic
Feat: Use React Query to fetch GitLogs in files
14cd7fc 
Ref: #27
mpetojevic added a commit that referenced this issue Apr 17, 2024
@mpetojevic
Fix: there is no need for explicit setting of properties using mutati…
108b246 
…ons in manual grading view,

because the data can be refetched.

Ref: #27
mpetojevic added a commit that referenced this issue Apr 17, 2024
@mpetojevic
Fix: Loading submission files when pulling submission in edit view su…
106c281 
…bmission was slow due to reloading whole

submission. Reload only sbumission files in such a case.

Ref: #27
mpetojevic added a commit that referenced this issue Apr 17, 2024
@mpetojevic
Fix: Bug that was present: When reloading the whole grading tale page…
21f2b3b 
… (this didn't happen when just navigating

through different tabs), regardless of the previously selected submissions to show - all, latest, best -
(before page reload), all submissions were rendered under chosen button which remained saved. So although
for example best is correctly selected, all submissions ('none' in code) were rendered.

Fixed the described behaviour. Now when for example LATEST submissions are selected, and the page is reloaded,
the latest submissions remain on the page correctly when the user enters the page back.

Ref: #27
mpetojevic added a commit that referenced this issue Apr 19, 2024
@mpetojevic
Fix: Restructured wrapping components into QueryClientProvider only t…
b6630f0 
…here where its really needed -> in highest parent components.

To do: This was done for course management -> do the same for assignments (student view).

Ref: #27
mpetojevic added a commit that referenced this issue Apr 29, 2024
@mpetojevic
Feat: Use react query in file-view (coursemenage) for refetching assi…
4c2191b 
…gnments.

Ref: #27
mpetojevic added a commit that referenced this issue Apr 29, 2024
@mpetojevic
Feat: use react query for fetching lecture and assignment in files.
a2d5a06 
Ref: #27
mpetojevic added a commit that referenced this issue Apr 29, 2024
@mpetojevic
Feat: use react query for setting directory ('source' or 'release') i…
7ca36ec 
…n files, when generating student

preview - release) of notebooks.

Ref: #27
mpetojevic added a commit that referenced this issue Apr 29, 2024
@mpetojevic
Feat: Use react query for repo status in files.
36a45df 
Ref: #27
mpetojevic added a commit that referenced this issue Apr 29, 2024
@mpetojevic
Feat: Use react query to refetch assignment after updating it in assi…
b13a2b8 
…gnment overview.

ref: #27
mpetojevic added a commit that referenced this issue Apr 29, 2024
@mpetojevic
Fix: Updated refetching files in the file list, because file list was…
fec2d3b 
…n't updated accordingly to the changes

in file browser.

Refactored structure of the QueryClientprovider so it is now called only once both for course and assignment menage.
This change had to be incoporated in widgets.

Ref: #27
mpetojevic added a commit that referenced this issue Apr 29, 2024
@mpetojevic
Fix: No need for react query in grading table, since we are working p…
9544517 
…redominantely with local states

(such as page number, rows per page, selected submissions etc.) which doesn't require fetching data.

Feat: Updated feedbac view to incoporate use of react query (student view).

Ref: #27
mpetojevic added a commit that referenced this issue Apr 29, 2024
@mpetojevic
Feat: Updated lecture (student view) to use react query for fetching …
f23462e 
…data.

Fix: Lecture (coursemanage) wasn't loading changes in assignment state right away. Changed that to reload
assignments and fetch most recent data using react query.

Ref: #27
mpetojevic added a commit that referenced this issue Apr 29, 2024
@mpetojevic
Added TODOs for utils regarding React Query.
ffa3cda 
Ref: #27
mpetojevic added a commit that referenced this issue Apr 30, 2024
@mpetojevic
Feat: Use react query to (re)fetch submissions and files in assignmen…
d5e087d 
…t view (student).

Ref: #27
mpetojevic added a commit that referenced this issue Apr 30, 2024
@mpetojevic
Feat: use react query to set date in deadlinedetail for assihnment in…
02dc1cd 
… student view, since

it is set once and than never changed (deadline is taken from the persistent data).

Ref: #27
mpetojevic added a commit that referenced this issue May 1, 2024
@mpetojevic
Manually merged release-0.4.1 branch and 27-new-caching-solution.
d49cca2 
Ref: #27
@mpetojevic mpetojevic linked a pull request May 1, 2024 that will close this issue
27 react query cachnig #45
Closed
@mpetojevic mpetojevic mentioned this issue May 1, 2024
Merged
mpetojevic added a commit that referenced this issue May 13, 2024
@mpetojevic
Removed @react-query-devtools from dependencies as they weren't used.…
076c846 
… Omitted unnecessary Typography element in edit-submission.tsx.

#27
mpetojevic added a commit that referenced this issue Jul 3, 2024
@mpetojevic
Merge pull request #46 from TU-Wien-dataLAB/27-react-query-cachnig
80a270c 
Manually merged release-0.4.1 branch and 27-new-caching-solution.

Closes #27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mpetojevic mpetojevic

Labels
enhancement New feature or request frontend needs-triage
Projects
None yet
Milestone
0.4.1
Development

Successfully merging a pull request may close this issue.

27 react query cachnig TU-Wien-dataLAB/Grader-Labextension
3 participants
@florian-jaeger @meffmadd @mpetojevic