Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94
Hi @ProfHoekstra, @jooste.
We're quite keen to get involved in helping with developing bluesky.
(Our company is SPARKL www.sparkl.com).
Specifically, this pull request concerns the 'tcp duplex' issue.
See example on: ethertricity#4
Also, pls see comments on original pull request:
ethertricity#9
I have taken the liberty of adding some tests.
I will also invite you to the slack channel where the output from our CI server goes.
You can run the tests by executing
make test
orpytest -s bluesky/test
withpython-pytest
installed.There are 4 simple tests for the tcp interface currently.
The changes are mostly trivial. Modules such as
BlueSky_qtgl.py
have been chopped around a little to make it more easy to use for tests.Pls feedback any questions, feedback, etc. Thanks - much appreciated
Andrew Farrell
Test run output: