Skip to content

Commit

Permalink
upate CONTRIBUTING doc
Browse files Browse the repository at this point in the history
  • Loading branch information
rogerkuou committed Jan 15, 2024
1 parent b20d203 commit 03552f7
Showing 1 changed file with 12 additions and 12 deletions.
24 changes: 12 additions & 12 deletions docs/CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# SARXarray Contributing Guidelines


We welcome any kind of contribution to our software, from simple comment
We welcome any kind of contribution to our software, from a simple comment
or question to a full fledged [pull request](https://help.github.com/articles/about-pull-requests/).
Please read and follow our [Code of Conduct](./CODE_OF_CONDUCT.md).

Expand All @@ -16,30 +16,30 @@ The sections below outline the steps in each case.

## You have a question

- use the search functionality [here](https://github.com/MotionbyLearning/sarxarray/issues)
- use the search functionality in [GitHub issue](https://github.com/TUDelftGeodesy/sarxarray/issues)
to see if someone already filed the same issue;
- if your issue search did not yield any relevant results, make a new issue;
- apply the "question" label; apply other labels when relevant.
- if your issue search did not yield any relevant results, create a new issue;
- add the "question" label; include other labels when relevant.

## You think you may have found a bug

- use the search functionality [here](https://github.com/MotionbyLearning/sarxarray/issues) to see if someone already filed the same issue;
- if your issue search did not yield any relevant results, make a new issue, making sure to provide enough information to the rest of the community to understand the cause and context of the problem. Depending on the issue, you may want to include:
- use the search functionality in [GitHub issue](https://github.com/TUDelftGeodesy/sarxarray/issues) to see if someone already filed the same issue;
- if your issue search did not yield any relevant results, create a new issue, making sure to provide enough information to the rest of the community to understand the cause and context of the problem. Depending on the issue, you may want to include:
- the [SHA hashcode](https://help.github.com/articles/autolinked-references-and-urls/#commit-shas>) of the commit that is causing your problem;
- some identifying information (name and version number) for dependencies you're using;
- information about the operating system;
- apply relevant labels to the newly created issue.
- add relevant labels to the newly created issue.

## You want to make some kind of change to the code base

- (**important**) announce your plan to the rest of the community *before you start working*. This announcement should be in the form of a (new) issue;
- (**important**) wait until some kind of consensus is reached about your idea being a good idea;
- if needed, fork the repository to your own Github profile and create your own feature branch off of the latest master commit. While working on your feature branch, make sure to stay up to date with the master branch by pulling in changes, possibly from the 'upstream' repository (follow the instructions [here](https://help.github.com/articles/configuring-a-remote-for-a-fork/) and [here](https://help.github.com/articles/syncing-a-fork/));
- make sure the existing tests still work. First, install the development dependencies as `pip install .[dev]`, and then run `pytest tests`;
- if needed, fork the repository to your own Github profile and create your own feature branch off of the latest master commit. While working on your feature branch, make sure to stay up to date with the master branch by pulling in changes, possibly from the 'upstream' repository (follow the instructions from GitHub: [instruction 1: configuring a remote for a fork](https://help.github.com/articles/configuring-a-remote-for-a-fork/) and [instruction 2: syncing a fork](https://help.github.com/articles/syncing-a-fork/));
- make sure the existing tests still work by running, e.g. `pytest tests`;
- add your own tests (if necessary);
- update or expand the documentation. Make sure the documentation is built successfully: first, install documentation dependencies as `pip install .[docs]` and then run `mkdocs build`.
- update or expand the documentation;
- make sure the linting tests pass by running `ruff` in the project root directory: `ruff check .`;
- [push](http://rogerdudler.github.io/git-guide/) your feature branch to (your fork of) the SARXarray repository on GitHub;
- create the pull request, e.g. following the instructions [here](https://help.github.com/articles/creating-a-pull-request/).
- [push](http://rogerdudler.github.io/git-guide/) your feature branch to (your fork of) the sarxarray repository on GitHub;
- create the pull request, e.g. following [the instructions: creating a pull request](https://help.github.com/articles/creating-a-pull-request/).

In case you feel like you've made a valuable contribution, but you don't know how to write or run tests for it, or how to generate the documentation: don't let this discourage you from making the pull request; we can help you! Just go ahead and submit the pull request, but keep in mind that you might be asked to append additional commits to your pull request.

0 comments on commit 03552f7

Please sign in to comment.