44 fix point selected on water #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @SarahAlidoost, this is a small fix for a bug. Can you review it when you have time? Thanks! |
SarahAlidoost
approved these changes
Mar 22, 2024
There was a problem hiding this comment.
@rogerkuou Thanks for fixing the issue and discussions on the pull request. Feel free to merge after resolving the conversations 👍
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
rogerkuou
force-pushed
the
44_fix_point_selected_on_water
branch
from
e21a355
to
9d8ea47
Compare
|
Thanks @SarahAlidoost for the review. I adapted your comments. |
|
Thanks @SarahAlidoost for the review. I adapeted your comments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #44.
According to docs xarray.DataArray.std and xarray.DataArray.mean, the default behavior of std and mean in xarray skips the nan values. However in ampplitude dispersion we do not want this since we would like nan values being discarded. Hence this fix.