Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

44 fix point selected on water #51

Merged
merged 5 commits into from
Mar 26, 2024
Merged

Conversation

rogerkuou
Copy link
Member

@rogerkuou rogerkuou commented Mar 18, 2024

Fix #44.

According to docs xarray.DataArray.std and xarray.DataArray.mean, the default behavior of std and mean in xarray skips the nan values. However in ampplitude dispersion we do not want this since we would like nan values being discarded. Hence this fix.

@rogerkuou
Copy link
Member Author

Hi @SarahAlidoost, this is a small fix for a bug. Can you review it when you have time? Thanks!

tests/test_stack.py Outdated Show resolved Hide resolved
tests/test_stack.py Outdated Show resolved Hide resolved
Copy link
Contributor

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogerkuou Thanks for fixing the issue and discussions on the pull request. Feel free to merge after resolving the conversations 👍

rogerkuou and others added 2 commits March 26, 2024 09:41
Co-authored-by: SarahAlidoost <55081872+SarahAlidoost@users.noreply.github.com>
@rogerkuou rogerkuou force-pushed the 44_fix_point_selected_on_water branch from e21a355 to 9d8ea47 Compare March 26, 2024 08:46
@rogerkuou
Copy link
Member Author

Thanks @SarahAlidoost for the review. I adapted your comments.

@rogerkuou
Copy link
Member Author

Thanks @SarahAlidoost for the review. I adapeted your comments.

@rogerkuou rogerkuou merged commit dbc97ec into main Mar 26, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Point selection method selects points in the water
2 participants