Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update and apply ruff standards #52

Merged
merged 5 commits into from
Nov 8, 2023
Merged

update and apply ruff standards #52

merged 5 commits into from
Nov 8, 2023

Conversation

rogerkuou
Copy link
Member

No description provided.

@rogerkuou rogerkuou marked this pull request as draft November 8, 2023 13:16
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 8, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

89.4% 89.4% Coverage
0.0% 0.0% Duplication

@rogerkuou
Copy link
Member Author

Hi @SarahAlidoost, I implemented more checks by ruff. In summary:

  1. I removed a wrong implementation "density" in subset function. This implementation was implemented as a draft in the beginning, turned out has flaws and I did not add test and docs for it. I documented an issue Density subsetting improvements #14 for this for later work.
  2. Added more tests for stm.py
  3. Renamed a varaible in add_metadata in stm.py from "points" to "dimension", to make it consistent with the simension name
  4. Other formatting problems

Could you please view it?

@rogerkuou rogerkuou marked this pull request as ready for review November 8, 2023 13:53
SarahAlidoost
SarahAlidoost approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@SarahAlidoost SarahAlidoost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rogerkuou thanks, looks good 🚀

@rogerkuou rogerkuou merged commit e2666e3 into main Nov 8, 2023
18 checks passed
@rogerkuou rogerkuou deleted the lint_test branch November 9, 2023 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SarahAlidoost SarahAlidoost SarahAlidoost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rogerkuou @SarahAlidoost