Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Adjust/Hide Events/Courses #170

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

PSandro
Copy link

@PSandro PSandro commented Jan 8, 2024

This is a rebase of #144
It is now possible to deselect specific events/courses after providing calendar link URL to CalendarProxy.

As discussed in #144, there are multiple ways to approach the filtering. It can be done by tag, by the full course name or the X-CO-RECURRINGID included in the event series.

For now, the full course name is used.

It is planned to also provide a feature for adjusting start- and endtimes of events. I'm unsure yet if this should be included here or in a followup PR.

@CommanderStorm CommanderStorm changed the title FR: Filter out Events/Courses Feature: Filter out Events/Courses Jan 9, 2024
@PSandro
Copy link
Author

PSandro commented Jan 15, 2024

I think it is a good idea to include the time adjustment feature in this PR since a change in the /api/courses endpoint might be required. In fact, I already changed the endpoint for this manner:

In my opinion in makes most sense to adjust the time of an event/course per recurrence-id. Example: A course has lectures on mondays and wednesdays every week. But the lecture on wednesdays always start 15 minutes later compared to what is originally set in the calendar. For this the user can take the recurrence id of the wednesdays lectures and apply a 15-minute offset.

For now the /api/courses endpoint is adjusted in a way so that the recurrences can be displayed.
image

@PSandro PSandro changed the title Feature: Filter out Events/Courses Feature: Adjust/Hide Events/Courses Jan 15, 2024
@PSandro
Copy link
Author

PSandro commented Feb 5, 2024

image
Courses can now be adjusted by selecting/setting an offset per "recurrence"/"reoccurrence". The offset value is also appended to the description of every event that is within that recurrence-series (has the same X-CO-RECURRINGID).
image

With the adjustments from above, this is what the calendar would look like:
The entries in white are from the adjusted iCal feed.
The ones in red are just for reference. This is from an iCal feed without adjustments.

image

I have also added a test, validating the functionality of time adjustments via offsets.

@PSandro PSandro marked this pull request as ready for review February 5, 2024 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants