Skip to content
This repository has been archived by the owner on Jan 10, 2024. It is now read-only.

Removed Faulty "invalidateOptionsMenu()" #1549

Merged
merged 1 commit into from
Dec 14, 2022
Merged

Removed Faulty "invalidateOptionsMenu()" #1549

merged 1 commit into from
Dec 14, 2022

Conversation

tobiasjungmann
Copy link
Contributor

@tobiasjungmann tobiasjungmann commented Dec 12, 2022 •
edited
Loading

Issue

#1547
This fixes the following issue(s):

  • Icon is now not set to the edit icon after the grades have been fetched from the server
  • Removed a dangling invalidateOptionsMenu() call which had no use.
  • Additionally cleared some uses of with(binding) in the grades fragment.

Screenshot

Will be added shortly

@tobiasjungmann tobiasjungmann changed the title removed faulty invalidateOptionsMenu Removed Faulty "invalidateOptionsMenu()" Dec 12, 2022
CommanderStorm
CommanderStorm approved these changes Dec 14, 2022
View reviewed changes
Copy link
Member

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this work, no complaints 🥳

@CommanderStorm CommanderStorm merged commit 4719b83 into master Dec 14, 2022
@CommanderStorm CommanderStorm deleted the bugfix-reset-edit-icon-issue-1547 branch December 14, 2022 22:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@CommanderStorm CommanderStorm CommanderStorm approved these changes

@joschahenningsen joschahenningsen Awaiting requested review from joschahenningsen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tobiasjungmann @CommanderStorm