Network Layer and Model Refactor #167
Conversation
…update # Conflicts: # Pods/Pods.xcodeproj/project.pbxproj # Pods/Target Support Files/Pods-Campus/Pods-Campus.debug.xcconfig # Pods/Target Support Files/Pods-Campus/Pods-Campus.release.xcconfig # TUM Campus App.xcodeproj/project.pbxproj
# Conflicts: # Pods/Pods.xcodeproj/project.pbxproj # Pods/Target Support Files/Pods-Campus/Pods-Campus-resources.sh # Pods/Target Support Files/Pods-Campus/Pods-Campus.debug.xcconfig # Pods/Target Support Files/Pods-Campus/Pods-Campus.release.xcconfig # TUM Campus App/TumDataManager.swift
# Conflicts: # Pods/Pods.xcodeproj/project.pbxproj
# Conflicts: # Podfile.lock # TUM Campus App.xcodeproj/project.pbxproj # TUM Campus App/CalendarManager.swift # TUM Campus App/Extensions.swift
|
@TG908 Can you please be more specific? |
|
I’m getting no Library Card and no success message on login. |
|
@mathiasquintero the card doesn't show up and when trying to log in theres no success alert |
|
I think i found the bug: |
|
@mathiasquintero Do you know if the search Manager can also search in categories like, people, rooms and lectures? |
|
@TG908 Ok. I'm fixing it |
|
@TG908 I don't unserstand your question. We don't have a single search manager. We have many that are concatenated whenever you perform a search. These search for People, Rooms and Lectures. But we can always extend them. Just look for We could make it search for books, or search for movies or search for Tum Sexy entries |
| keychainWrapper.writeToKeychain() | ||
| UserDefaults.standard.synchronize() | ||
| } | ||
| // TODO: Refactor use of keychain wrapper |
There was a problem hiding this comment.
| UserDefaults.standard.synchronize() | ||
| } | ||
| // TODO: Refactor use of keychain wrapper | ||
| // TODO: Move this to the manager. This is really the managers job. |
There was a problem hiding this comment.
|
I think we should create a new branch and start integration of all the changes. |
|
@TG908 I'm not sure what you mean by integration. This is all integrated. What we're missing is the new Cards and UIs we have planned |
Did you change the search controller ? I want to add a segment control to the search bar. Also for the new Cards/UI we need a fully integrated branch |
|
@TG908 I haven't changed the search controller in any way, other than how to get the data... But it shouldn't be a problem to add later. This branch isn't supposed to add new features and can be merged alone. Hows your progress going in #192 going? |
|
SonarQube analysis reported 4 issues
Watch the comments in this conversation to review them. |
This redoes the entire networking layer and removes SwiftyJSON and Alamofire from our dependencies.
It makes our networking a bit more type-safe and relies less on casting.
And it introduces caching
Fixes #72
Fixes #109
Starts progress in #43 & #165
Fixes #156
Fixes #90
While I was at it I also fixed: #121 with the same workaround as android