Skip to content

Commit

Permalink
implemented the success slot of the modal
Browse files Browse the repository at this point in the history
  • Loading branch information
CommanderStorm committed Jun 19, 2023
1 parent c0f4cc8 commit 7e9489e
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 3 deletions.
8 changes: 7 additions & 1 deletion webclient/src/components/feedback/EditRequestModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,13 @@ const global = useGlobalStore();
<h2>{{ $t("feedback.coordinates") }}</h2>
coordinates can be previewed here
</template>
<template v-slot:success> success </template>
<template v-slot:success="{ successUrl }">
<p>{{ $t("feedback.success.thank_you") }}</p>
<p>
{{ $t("feedback.success.response_at") }}
<a id="feedback-success-url" class="btn-link" :href="successUrl">{{ $t("feedback.success.this_pull_request") }}</a>

Check notice on line 28 in webclient/src/components/feedback/EditRequestModal.vue

View check run for this annotation

Codacy Production / Codacy Static Code Analysis

webclient/src/components/feedback/EditRequestModal.vue#L28

Replace `·$t("feedback.success.this_pull_request")` with `⏎··········$t("feedback.success.this_pull_request")⏎·······`
</p>
</template>
</BasicFeedbackModal>
</template>

Expand Down
2 changes: 1 addition & 1 deletion webclient/src/components/feedback/FeedbackModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ const deleteIssueRequested = ref(false);
</label>
</div>
</template>
<template v-slot:success>
<template v-slot:success="{ successUrl }">
<p>{{ $t("feedback.success.thank_you") }}</p>
<p>
{{ $t("feedback.success.response_at") }}
Expand Down
2 changes: 1 addition & 1 deletion webclient/src/components/feedback/TokenBasedModal.vue
Original file line number Diff line number Diff line change
Expand Up @@ -171,7 +171,7 @@ function sendForm() {
</div>
<div class="modal-body">
<div class="content">
<slot name="success" />
<slot name="success" :successUrl="successUrl" />

<div class="buttons">
<button class="btn btn-primary" @click="closeForm">
Expand Down
1 change: 1 addition & 0 deletions webclient/src/locales/de.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ feedback:
response_at: Antwort auf dein Feedback findest du auf
thank_you: Vielen Dank für dein Feedback! Wir werden es schnellstmöglich bearbeiten.
this_issue: diesem GitHub Issue
this_pull_request: diesem GitHub Pull Request
title: Vielen Dank!
title: Feedback senden
type:
Expand Down
1 change: 1 addition & 0 deletions webclient/src/locales/en.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,7 @@ feedback:
response_at: You can see our response at
thank_you: Thank you for giving your feedback. We will work on this as soon as possible.
this_issue: this GitHub issue
this_pull_request: this GitHub pull request
title: Thank you!
title: Send Feedback
type:
Expand Down

0 comments on commit 7e9489e

Please sign in to comment.