Refactored Scaper #263
Merged
Refactored Scaper #263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CommanderStorm
added
the
data
CommanderStorm
force-pushed
the
scraper_refactoring
branch
3 times, most recently
from
fac3dd1
to
4fd47c8
Compare
octycs
approved these changes
Nov 1, 2022
CommanderStorm
force-pushed
the
scraper_refactoring
branch
from
4fd47c8
to
55b10af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR refactors the scaper from one single blob to more split up collection.
This is a preparation for #34, as this will increase the complexity of the scraper slightly and I think this way this is more managable