Staticcheck fixes / input sanitation #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joschahenningsen
requested changes
Feb 22, 2024
| @@ -57,7 +57,7 @@ func generateKey(org, country, province, locality, streetAddress, postalCode, cn | |||
| return err | |||
| } | |||
| defer file.Close() | |||
| _, err = file.Write(caPEM.Bytes()) | |||
| file.Write(caPEM.Bytes()) | |||
There was a problem hiding this comment.
tbh we should do something with the err
| @@ -72,6 +72,6 @@ func generateKey(org, country, province, locality, streetAddress, postalCode, cn | |||
| return err | |||
| } | |||
| defer keyF.Close() | |||
| _, err = keyF.Write(caPrivKeyPEM.Bytes()) | |||
| keyF.Write(caPrivKeyPEM.Bytes()) | |||
There was a problem hiding this comment.
Here as well, even if just returning it
| @@ -35,7 +35,7 @@ func (m *MatrixMessenger) SendMessage(title string, message Message, reportURL s | |||
| if err != nil { | |||
| return err | |||
| } | |||
| resp, err := http.Post( | |||
| resp, _ := http.Post( | |||
There was a problem hiding this comment.
Let's not ignore errors, return them instead
| err := mail.SendMail( | ||
| a.config.Mail.User, a.config.Mail.Password, | ||
| a.config.Mail.SMTPServer, a.config.Mail.SMTPPort, | ||
| a.config.Mail.FromName, a.config.Mail.From, topic.Email, | ||
| fmt.Sprintf("[%s]: report #%d updated", topic.Name.En, report.ID), | ||
| "Hi, there is a new message regarding "+topic.Name.En+":\n\n"+c.PostForm("reply")+"\n\nYou can reply to it <a href=\""+a.config.URL+"/report?administratorToken="+report.AdministratorToken+"\">here</a>.") | ||
| "Hi, there is a new message regarding "+topic.Name.En+":\n\n"+string(message.GetBody())+"\n\nYou can reply to it <a href=\""+a.config.URL+"/report?administratorToken="+report.AdministratorToken+"\">here</a>.") |
There was a problem hiding this comment.
Agreed that this should be done, but it has some implications: Instead of sending the raw message, we now convert it to html and send that. Have you tested that this renders as expected?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses unused err variables and adds sanitation to the user input in the reply route.