Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actix-web requirement from 3 to 4 in /server #49

Merged
merged 4 commits into from Mar 5, 2022

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Feb 28, 2022

Updates the requirements on actix-web to permit the latest version.

Release notes

Sourced from actix-web's releases.

actix-web: v4.0.1

Fixed

  • Use stable version in readme example.
Commits

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on [actix-web](https://github.com/actix/actix-web) to permit the latest version.
- [Release notes](https://github.com/actix/actix-web/releases)
- [Changelog](https://github.com/actix/actix-web/blob/master/CHANGES.md)
- [Commits](actix/actix-web@web-v3.0.0...web-v4.0.1)

---
updated-dependencies:
- dependency-name: actix-web
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @github
Copy link
Contributor Author

dependabot bot commented on behalf of github Mar 3, 2022

Dependabot tried to update this pull request, but something went wrong. We're looking into it, but in the meantime you can retry the update by commenting @dependabot rebase.

@CommanderStorm
Copy link
Member

@dependabot rebase

@CommanderStorm
Copy link
Member

This seems major and I think, that you should look into this, once your exam phase is over @octycs

@CommanderStorm
Copy link
Member

I have followed the migration guide, but I have one question left:
Only decision on my front that may be questionable is #[actix_web::main] vs #[tokio::main](see migration guide):
I am unable to get #[tokio::main] to work. There is something very basic that I cannot wrap my head around and I dont know what the issue is

@CommanderStorm
Copy link
Member

I have tested the server and it looks good to me.
There are a few tests that are failing, but those are failing on master too..

This branch:
main

main:
main

@TUM-Dev TUM-Dev deleted a comment from dependabot bot Mar 4, 2022
@TUM-Dev TUM-Dev deleted a comment from dependabot bot Mar 4, 2022
@octycs
Copy link
Contributor

octycs commented Mar 5, 2022

I just tested it as well and it seems to work fine. Thank you for migrating.
Unfortunately it appears to be around 7% slower now, but it would probably require a lot of time to find out why, and I don't think it is too severe.

I think we can merge this.

@CommanderStorm
Copy link
Member

@CommanderStorm CommanderStorm merged commit be35287 into main Mar 5, 2022
@dependabot dependabot bot deleted the dependabot/cargo/server/actix-web-4 branch March 5, 2022 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants