Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing three point circle brush #346

Open
wants to merge 4 commits into
base: sponge-1.12
Choose a base branch
from

Conversation

nlipiarski
Copy link

@nlipiarski nlipiarski commented Nov 21, 2019

This pull request reimplements the 3 point circle brush so that it actually functions correctly. The brush now uses a system of equations to find the center point of the circle as well as a parametric description of the circle to more efficiently place the blocks in the circle. Because of these two changes, I removed the smoothness vs accuracy attribute as the circles are created in a way that is both accurate and smooth.

#299

@gabizou gabizou added this to PR's To Review in 2020 Project Cleanup May 2, 2020
@gabizou gabizou added the sponge Sponge version of VS label May 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sponge Sponge version of VS
Projects
2020 Project Cleanup
  
PR's To Review
Development

Successfully merging this pull request may close these issues.

None yet

2 participants