Skip to content
This repository has been archived by the owner on Jan 18, 2020. It is now read-only.

Consistency #56

Open
3 of 10 tasks
Siguza opened this issue Nov 2, 2014 · 0 comments
Open
3 of 10 tasks

Consistency #56

Siguza opened this issue Nov 2, 2014 · 0 comments
Labels
status-accepted type-refactor
Milestone
2.0

Comments

@Siguza
Copy link
Contributor

Siguza commented Nov 2, 2014

Things that need to be more consistent:

  • Names:
    • Classes (always use UpperCamelCase, never _)
    • Methods (always use lowerCamelCase, never _)
    • Variables (always use lowerCamelCase and long names ("$level" instead of "$lvl", or "$luck" instead of "$_g")):
      • Templates
      • Language files
  • Template paths (in particular: move hide, wall, storage and res in twlan/controllers/game/...)
  • The choice of names (eg. always "ally", never "tribe")
  • Rounding (e.g. 1 second is always added for buildings in the queue)
  • Reduce code duplication (especially in templates: Split more stuff in "widgets", to reuse components)

This is essential for any API.
@Siguza Siguza added this to the 2.0 release milestone Nov 2, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
status-accepted type-refactor
Projects
None yet
Milestone
2.0
Development

No branches or pull requests
1 participant
@Siguza