Fix #301: remove suppressions of AllowBackup (#321)

TWiStErRob · Aug 25, 2023 · a8fb3eb · a8fb3eb
1 parent 1e31a1c
commit a8fb3eb
Show file tree

Hide file tree

Showing 4 changed files with 0 additions and 13 deletions.
diff --git a/android/data/svg/src/main/AndroidManifest.xml b/android/data/svg/src/main/AndroidManifest.xml
@@ -1,14 +1,10 @@
 <manifest
 	xmlns:android="http://schemas.android.com/apk/res/android"
-	xmlns:tools="http://schemas.android.com/tools"
 	>
 
 	<application
 		android:icon="@android:drawable/sym_def_app_icon"
-		android:allowBackup="false"
-		tools:ignore="DataExtractionRules"
 		>
-		<!-- lint:DataExtractionRules not necessary for this test app. -->
 	</application>
 
 </manifest>
diff --git a/android/src/debug/AndroidManifest.xml b/android/src/debug/AndroidManifest.xml
@@ -9,10 +9,8 @@
 
 	<application
 		android:name="net.twisterrob.inventory.android.DebugApp"
-		tools:ignore="AllowBackup"
 		tools:replace="android:name"
 		>
-		<!-- lint:AllowBackup REPORT false positive, because main/AndroidManifest.xml is set up. -->
 
 		<!--suppress AndroidDomInspection workaround for https://github.com/TWiStErRob/net.twisterrob.inventory/issues/309 -->
 		<activity

diff --git a/android/src/main/AndroidManifest.xml b/android/src/main/AndroidManifest.xml
@@ -14,10 +14,7 @@
 		android:manageSpaceActivity="net.twisterrob.inventory.android.space.ManageSpaceActivity"
 		android:supportsRtl="true"
 		android:theme="@style/Theme.AppTheme"
-		tools:ignore="AllowBackup"
 		>
-		<!-- lint:AllowBackup not using fullBackupContent, default "Auto Backup" is fine.
-		     TODO review in https://github.com/TWiStErRob/net.twisterrob.inventory/issues/301 -->
 
 		<meta-data
 			android:name="net.twisterrob.inventory.android.Constants$Pic$GlideSetup"

diff --git a/android/src/release/AndroidManifest.xml b/android/src/release/AndroidManifest.xml
@@ -1,17 +1,13 @@
 <?xml version="1.0" encoding="utf-8"?>
 <manifest
 	xmlns:android="http://schemas.android.com/apk/res/android"
-	xmlns:tools="http://schemas.android.com/tools"
 	>
 
 	<application
 		android:largeHeap="true"
-		tools:ignore="AllowBackup,UnusedAttribute"
 		>
 		<!-- largeHeap to prevent OOMs (e.g. cropping),
 		     but only do it in release to force memory problems to come up during development. -->
-		<!-- lint:UnusedAttribute largeHeap is API 11+, using as best effort. -->
-		<!-- lint:AllowBackup REPORT false positive, because main/AndroidManifest.xml is set up. -->
 	</application>
 
 </manifest>