Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create notifications with channel ID using builder #164

Open
TWiStErRob opened this issue Apr 26, 2020 · 1 comment
Open

Create notifications with channel ID using builder #164

TWiStErRob opened this issue Apr 26, 2020 · 1 comment
Labels
a:enhancement bettering of an existing feature in:internals internal change without functional change
Milestone
Backlog

Comments

@TWiStErRob
Copy link
Owner

Remove workaround of setting notification channel via reflection in BackupService.
@TWiStErRob TWiStErRob added a:enhancement bettering of an existing feature in:internals internal change without functional change labels Apr 26, 2020
@TWiStErRob TWiStErRob added this to the AndroidX milestone Apr 26, 2020
@TWiStErRob
Copy link
Owner Author

This is halfway fixed in svn@3205, the channel ID is actually set up, but there's a workaround with FAKE_CHANNEL_ID, because at the time of construction the channel ID is not known. Still need to refactor the order of code to remove this constant and be safe and nice.

TWiStErRob added a commit to TWiStErRob/net.twisterrob.libraries that referenced this issue Feb 24, 2023
@TWiStErRob
[SVN] r3205 Inventory in /Libraries/twister-lib-android/
94dc603 
[MOD] Use latest support library (28.0.0) in the app
[EXP] TWiStErRob/net.twisterrob.inventory#164 work around NotificationCompat.Builder's deprecated constructor via FAKE_CHANNEL_ID
[REM] TWiStErRob/net.twisterrob.inventory#164 Inline deprecated methods to use their API 14+ equivalents.
[EXP] Polyfill getLoadManager/getSupportLoaderManager in variants to reduce changes.
[REM] LoaderManager.mWho reflective accesses as that field doesn't exist any more.
[REF] Rewrite EdgeEffect related debug helpers for Android SDK instead of deprecated support lib version.
TWiStErRob added a commit that referenced this issue Feb 24, 2023
@TWiStErRob
[SVN] r3205 Inventory in /Libraries/twister-lib-android/
16c06a3 
[MOD] Use latest support library (28.0.0) in the app
[EXP] #164 work around NotificationCompat.Builder's deprecated constructor via FAKE_CHANNEL_ID
[REM] #164 Inline deprecated methods to use their API 14+ equivalents.
[EXP] Polyfill getLoadManager/getSupportLoaderManager in variants to reduce changes.
[REM] LoaderManager.mWho reflective accesses as that field doesn't exist any more.
[REF] Rewrite EdgeEffect related debug helpers for Android SDK instead of deprecated support lib version.
@TWiStErRob TWiStErRob mentioned this issue Mar 15, 2023
Closed
@TWiStErRob TWiStErRob modified the milestones: v1.2.0 AndroidX, Backlog Jul 27, 2023
TWiStErRob added a commit to TWiStErRob/net.twisterrob.travel that referenced this issue Nov 19, 2023
@TWiStErRob
[SVN] r3205 Inventory in /Libraries/twister-lib-android/
9cb59da 
[MOD] Use latest support library (28.0.0) in the app
[EXP] TWiStErRob/net.twisterrob.inventory#164 work around NotificationCompat.Builder's deprecated constructor via FAKE_CHANNEL_ID
[REM] TWiStErRob/net.twisterrob.inventory#164 Inline deprecated methods to use their API 14+ equivalents.
[EXP] Polyfill getLoadManager/getSupportLoaderManager in variants to reduce changes.
[REM] LoaderManager.mWho reflective accesses as that field doesn't exist any more.
[REF] Rewrite EdgeEffect related debug helpers for Android SDK instead of deprecated support lib version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
a:enhancement bettering of an existing feature in:internals internal change without functional change
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
1 participant
@TWiStErRob