Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #301: remove suppressions of AllowBackup #321

Merged
merged 4 commits into from
Aug 25, 2023
Merged

Fix #301: remove suppressions of AllowBackup #321

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
fb1dcda
Remove all mentions of allowBackup
TWiStErRob Aug 25, 2023
4daf6f7
Remove outdated suppression
TWiStErRob Aug 25, 2023
9f4e3c9
Re-enable explicitly in case a library defines it.
TWiStErRob Aug 25, 2023
4322529
Merge branch 'main' into fix301
TWiStErRob Aug 25, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions android/data/svg/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
<manifest
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
>

<application
android:icon="@android:drawable/sym_def_app_icon"
android:allowBackup="false"
tools:ignore="DataExtractionRules"
>
<!-- lint:DataExtractionRules not necessary for this test app. -->
</application>

</manifest>
2 changes: 0 additions & 2 deletions android/src/debug/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,8 @@

<application
android:name="net.twisterrob.inventory.android.DebugApp"
tools:ignore="AllowBackup"
tools:replace="android:name"
>
<!-- lint:AllowBackup REPORT false positive, because main/AndroidManifest.xml is set up. -->

<!--suppress AndroidDomInspection workaround for https://github.com/TWiStErRob/net.twisterrob.inventory/issues/309 -->
<activity
Expand Down
3 changes: 0 additions & 3 deletions android/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,7 @@
android:manageSpaceActivity="net.twisterrob.inventory.android.space.ManageSpaceActivity"
android:supportsRtl="true"
android:theme="@style/Theme.AppTheme"
tools:ignore="AllowBackup"
>
<!-- lint:AllowBackup not using fullBackupContent, default "Auto Backup" is fine.
TODO review in https://github.com/TWiStErRob/net.twisterrob.inventory/issues/301 -->

<meta-data
android:name="net.twisterrob.inventory.android.Constants$Pic$GlideSetup"
Expand Down
4 changes: 0 additions & 4 deletions android/src/release/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,13 @@
<?xml version="1.0" encoding="utf-8"?>
<manifest
xmlns:android="http://schemas.android.com/apk/res/android"
xmlns:tools="http://schemas.android.com/tools"
>

<application
android:largeHeap="true"
tools:ignore="AllowBackup,UnusedAttribute"
>
<!-- largeHeap to prevent OOMs (e.g. cropping),
but only do it in release to force memory problems to come up during development. -->
<!-- lint:UnusedAttribute largeHeap is API 11+, using as best effort. -->
<!-- lint:AllowBackup REPORT false positive, because main/AndroidManifest.xml is set up. -->
</application>

</manifest>
Loading