Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: merge ymls #97

Closed
TWiStErRob opened this issue Jun 9, 2022 · 0 comments · Fixed by #101
Closed

CI: merge ymls #97

TWiStErRob opened this issue Jun 9, 2022 · 0 comments · Fixed by #101
Labels
enhancement New feature or request
Milestone
1.2.2

Comments

@TWiStErRob
Copy link
Owner

Need to merge ymls because at the moment the Verify task fails the same time as build, but by the time record completes we know if there's a point in trying.

Solution: block verify on build, but only the Gradle part. Lint/detekt problems should let it through.
@TWiStErRob TWiStErRob added the enhancement New feature or request label Jun 9, 2022
@TWiStErRob TWiStErRob added this to the vNext milestone Jun 9, 2022
@TWiStErRob TWiStErRob mentioned this issue Jun 11, 2022
Merged
TWiStErRob added a commit that referenced this issue Jun 11, 2022
@TWiStErRob
Fix #97: Merge CI and Screenshot workflows (#101)
1fd65fe 
* Merge workflows
* Remove trigger to reduce duplicates
* determine PR
* Make Unit tests pass Gradle build
* Remove unnecessary complexity: build job now passes even if unit/static fails.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.2
Development

Successfully merging a pull request may close this issue.

Fix #97: Merge CI and Screenshot workflows TWiStErRob/net.twisterrob.sun
1 participant
@TWiStErRob