[FEATURE] Extend the task "install:fixfolderstructure" to create configured extension directories #290

websi · 2016-09-14T12:54:50Z

No description provided.

fsaris · 2016-09-14T16:22:05Z

Isn't this covered by extension:setupactive?

helhum · 2016-09-14T18:22:51Z

Isn't this covered by extension:setupactive?

Yes, it is.

@websi can you describe the use case of having a command that creates directories only?

websi · 2016-09-15T07:20:50Z

This is not a part of extension:setupactiv. This is only a part of extension:activate.

Our use case is an automatic deployment of TYPO3.
So we don't want to setup every extension at every deployment run.

Also we don't want to write the LocalConfiguration.php at an deployment run.
We configure the extensions in a git repository and release that.

bauschan · 2016-10-17T14:46:59Z

Any news here?

helhum · 2016-11-09T22:51:10Z

Will be fixed with https://review.typo3.org/#/c/50561

helhum · 2016-11-09T22:56:52Z

Also we don't want to write the LocalConfiguration.php at an deployment run.

That is indeed unfortunate, but does not harm, except that the file (system) needs to be writable.
That is a conceptual issue which should also be handled on TYPO3 side.

But to put everything aside, I think it would be great to let the install:fixfolderstructure command handle the folder creation also for extensions.

…igured extension directories

Conflicts: Classes/Command/InstallCommandController.php Configuration/Console/Commands.php

helhum

Thanks a lot for working on this.

Two things here.

First, please remove all re-formatting from the change. Mixing code style changes with other changes, makes the actual changes much harder to read and the PR harder to review. Besides that, it adds unnecessary additional potential discussions about a topic that needs to discussed separately.

Second and most importantly, we need to follow a different approach for creating extension folders. Since TYPO3 has no API for that, we need to create it. This fix foldersturcture command needs to stay low level.

Thanks again for your efforts! I'd be happy to support you in changing the code in the direction I mentioned. If you have questions, feel free to ask.

helhum · 2016-12-20T09:22:40Z

Classes/Command/InstallCommandController.php

@@ -41,24 +42,24 @@ class InstallCommandController extends CommandController
    protected $packageStatesGenerator;

    /**
-     * TYPO3 Setup
+     * TYPO3 Setup.


Full stops in the headline have been removed in #256 and should stay removed.

The docheader comments are used for documentation and to show the help texts. Having them consistent matters

helhum · 2016-12-20T09:26:00Z

Classes/Command/InstallCommandController.php

-     * @param bool $nonInteractive If specified, optional arguments are not requested, but default values are assumed.
-     * @param bool $force Force installation of TYPO3, even if <code>LocalConfiguration.php</code> file already exists.
-     * @param string $databaseUserName User name for database server
+     * @param bool   $nonInteractive       If specified, optional arguments are not requested, but default values are assumed.


Hm, this might affect the documentation and help texts as well. Besides that, all other classes are formatted with a single space to separate the argument types, names and description.

I have no plans to change that

helhum · 2016-12-20T09:27:44Z

Classes/Command/InstallCommandController.php

@@ -115,22 +117,23 @@ public function generatePackageStatesCommand($removeInactive = false, $activateD
                if (empty($activePackages[$package->getPackageKey()])) {
                    $this->packageManager->unregisterPackage($package);
                    GeneralUtility::flushDirectory($package->getPackagePath());
-                    $this->outputLine('Removed Package: ' . $package->getPackageKey());
+                    $this->outputLine('Removed Package: '.$package->getPackageKey());


This violates the code style. There should even be a fixer defined in .php_cs that adds the spaces

helhum · 2016-12-20T09:33:49Z

Configuration/Console/Commands.php

-        'typo3_console:configuration:*' => \Helhum\Typo3Console\Core\Booting\RunLevel::LEVEL_MINIMAL ,
+        'typo3_console:install:databasedata'         => \Helhum\Typo3Console\Core\Booting\RunLevel::LEVEL_MINIMAL,
+        'typo3_console:install:defaultconfiguration' => \Helhum\Typo3Console\Core\Booting\RunLevel::LEVEL_MINIMAL,
+        'typo3_console:install:fixfolderstructure'   => \Helhum\Typo3Console\Core\Booting\RunLevel::LEVEL_FULL,


That is a breaking change and also a rather severe one. It limits this command to be only executable with a full db connection, which isn't the case on a build system, which creates the package to be deployed. The command must stay very low level.

helhum · 2016-12-20T09:37:07Z

Classes/Command/InstallCommandController.php

@@ -149,10 +152,20 @@ public function fixFolderStructureCommand()
                $this->outputLine($fixedStatusObject->getTitle());
            }
        }
+
+        /** @var $installUtility \TYPO3\CMS\Extensionmanager\Utility\InstallUtility */
+        $installUtility = $this->objectManager->get(\TYPO3\CMS\Extensionmanager\Utility\InstallUtility::class);


as pointed out below, we can't simply do it like this unfortunately.

My idea is to gather the information (folders to be created) from all active extensions and put this info into the array of to be created folders and let the folder structure facade create the folders

This reverts commit af8ae5b.

This reverts commit 43f7811.

…igured extension directories

helhum · 2016-12-21T12:38:13Z

Classes/Command/InstallCommandController.php

     *
     * This command is great e.g. for creating the typo3temp folder structure during deployment
     *
     * @throws \TYPO3\CMS\Install\FolderStructure\Exception
     * @throws \TYPO3\CMS\Install\Status\Exception
+     * @throws \TYPO3\CMS\Extensionmanager\Exception\ExtensionManagerException


is this still the case?

No, can be removed.

helhum · 2016-12-22T00:03:49Z

Awesome! Thanks a lot for your work @websi !

helhum · 2016-12-22T00:05:25Z

… and your patience to apply all the requested changes.

Add task to create configured directories for installed extensions

c58a3cc

helhum added the Needs feedback from PR author label Sep 14, 2016

helhum mentioned this pull request Nov 9, 2016

Create uploads folder feature #175

Closed

websi added 2 commits December 16, 2016 12:26

[FEATURE] Extend the task "install:fixfolderstructure" to create conf…

94e2f2e

…igured extension directories

Remove empty line

dc292cf

websi changed the title ~~[FEATURE] Add task to create configured directories for installed extensions~~ [FEATURE] Extend the task "install:fixfolderstructure" to create configured extension directories Dec 16, 2016

websi added 3 commits December 16, 2016 13:16

Remove errors reported by StyleCI

43f7811

Merge branch 'master' into extension_directories

14be04d

Conflicts: Classes/Command/InstallCommandController.php Configuration/Console/Commands.php

Remove errors reported by StyleCI

af8ae5b

helhum requested changes Dec 20, 2016

View reviewed changes

websi added 3 commits December 20, 2016 11:08

Revert "Remove errors reported by StyleCI"

ecc1353

This reverts commit af8ae5b.

Revert "Remove errors reported by StyleCI"

9009c6e

This reverts commit 43f7811.

[FEATURE] Extend the task "install:fixfolderstructure" to create conf…

23b730f

…igured extension directories

helhum reviewed Dec 21, 2016

View reviewed changes

helhum and others added 8 commits December 21, 2016 13:42

Merge branch 'master' into extension_directories

77e84e2

Update PHPDoc. Remove not needed documentation for "throws"

d60ba99

Fix coding style

24905ea

Improve docheader and apply changes to reference manual

0dbe90c

Move folder structure class to install namespace

5a7226e

Streamline structure creation

c5a31d6

use package manager api directly

6ee7831

fix class comments

b71d3cc

helhum approved these changes Dec 22, 2016

View reviewed changes

helhum merged commit 6984793 into TYPO3-Console:master Dec 22, 2016

websi mentioned this pull request Apr 6, 2017

[FEATURE] Import extension static database content #288

Closed

websi deleted the extension_directories branch April 6, 2017 12:39

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE] Extend the task "install:fixfolderstructure" to create configured extension directories #290

[FEATURE] Extend the task "install:fixfolderstructure" to create configured extension directories #290

websi commented Sep 14, 2016

fsaris commented Sep 14, 2016

helhum commented Sep 14, 2016

websi commented Sep 15, 2016

bauschan commented Oct 17, 2016

helhum commented Nov 9, 2016

helhum commented Nov 9, 2016

helhum left a comment

helhum Dec 20, 2016 •

edited

helhum Dec 20, 2016

helhum Dec 20, 2016

helhum Dec 20, 2016 •

edited

helhum Dec 20, 2016

helhum Dec 21, 2016

websi Dec 21, 2016

helhum commented Dec 22, 2016

helhum commented Dec 22, 2016

[FEATURE] Extend the task "install:fixfolderstructure" to create configured extension directories #290

[FEATURE] Extend the task "install:fixfolderstructure" to create configured extension directories #290

Conversation

websi commented Sep 14, 2016

fsaris commented Sep 14, 2016

helhum commented Sep 14, 2016

websi commented Sep 15, 2016

bauschan commented Oct 17, 2016

helhum commented Nov 9, 2016

helhum commented Nov 9, 2016

helhum left a comment

Choose a reason for hiding this comment

helhum Dec 20, 2016 • edited

Choose a reason for hiding this comment

helhum Dec 20, 2016

Choose a reason for hiding this comment

helhum Dec 20, 2016

Choose a reason for hiding this comment

helhum Dec 20, 2016 • edited

Choose a reason for hiding this comment

helhum Dec 20, 2016

Choose a reason for hiding this comment

helhum Dec 21, 2016

Choose a reason for hiding this comment

websi Dec 21, 2016

Choose a reason for hiding this comment

helhum commented Dec 22, 2016

helhum commented Dec 22, 2016

helhum Dec 20, 2016 •

edited

helhum Dec 20, 2016 •

edited