Introduce PHP linting and code styles #361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brotkrueml
requested changes
May 2, 2023
With #360 PHP files that need code-styles applied have been introduce. releases: main, 12.4
brotkrueml
reviewed
May 8, 2023
|
@brotkrueml I applied the changes, please have another look |
sbuerk
requested changes
May 21, 2023
sbuerk
reviewed
May 21, 2023
The `Build/Scripts/runTests.sh` transactor provides
the flag `-u` to enforce updated used images.
The provided core-testing images are now used from
the `GitHub Container Registry` and therefore an
`${IMAGE_PREFIX}` variable have been introduced to
the `runTests.sh` script.
It has been missed to use the same prefix variable
for the updating and cleanup executed using `-u`.
This change now also uses the image prefix variable
for the update command.
Previously the docker-compose project name have been set hardcoded to `local`. With raising use of `docker compose v2` this may interfere with other projects, extensions and repositories. To avoid a cross over interference we ensure to use a unique docker-compose project name in this repository.
sbuerk
approved these changes
May 21, 2023
|
@linawolf Just a reminder: you have to take care when backporting to 12.4 that the Core versions in composer.json get adjusted from |
brotkrueml
approved these changes
May 21, 2023
|
Right, thanks, I will backport manually |
linawolf
added a commit
that referenced
this pull request
May 21, 2023
* Introduce PHP linting and code styles With #360 PHP files that need code-styles applied have been introduce. releases: main, 12.4 * Use latest versions * Apply changes required by tests * Apply changes required by tests * Apply changes required by code-review * [TASK] Use the `${IMAGE_PREFIX}` prefix for image updates The `Build/Scripts/runTests.sh` transactor provides the flag `-u` to enforce updated used images. The provided core-testing images are now used from the `GitHub Container Registry` and therefore an `${IMAGE_PREFIX}` variable have been introduced to the `runTests.sh` script. It has been missed to use the same prefix variable for the updating and cleanup executed using `-u`. This change now also uses the image prefix variable for the update command. * [TASK] Ensure a unique docker-compose project name Previously the docker-compose project name have been set hardcoded to `local`. With raising use of `docker compose v2` this may interfere with other projects, extensions and repositories. To avoid a cross over interference we ensure to use a unique docker-compose project name in this repository. --------- Co-authored-by: Stefan Bürk <stefan@buerk.tech> (cherry picked from commit d76ad83)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With #360 PHP files that need code-styles applied have been introduce.
releases: main, 12.4