[TASK] Add static code analyser PHPStan as code quality check
#262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brotkrueml
reviewed
May 1, 2024
|
As you can read in the description this Depends on #261 |
|
Then please, set it as draft. |
|
It is absolutely your right to decide like this |
linawolf
force-pushed
the
task/phpstan
branch
2 times, most recently
from
8203a9d
to
597d215
Compare
sbuerk
requested changes
May 3, 2024
The TYPO3 Core and the Best Practice Team recommends to have a static code analyzer in the defense line, and preferes PHPStan due to experience with that tool. This change now adds the static code analyser `PHPStan` with a first configurattion and a lower level as a start. Levels can be raised step by step in follow-ups. Note: XClass `Classes/Xclass/NewRecordController.php` example does not work anymore, most likely since v12. Added a comment to emphasize this, and that it should be reworked or removed. PHPStan can be run with ```terminal Build/Scripts/runTests.sh -s phpstan ``` Generate baseline with ```terminal Build/Scripts/runTests.sh -s phpstanBaseline ```
sbuerk
changed the title
PHPStan as code quality check
sbuerk
approved these changes
May 3, 2024
linawolf
added a commit
that referenced
this pull request
May 4, 2024
The TYPO3 Core and the Best Practice Team recommends to have a static code analyzer in the defense line, and preferes PHPStan due to experience with that tool. This change now adds the static code analyser `PHPStan` with a first configurattion and a lower level as a start. Levels can be raised step by step in follow-ups. Note: XClass `Classes/Xclass/NewRecordController.php` example does not work anymore, most likely since v12. Added a comment to emphasize this, and that it should be reworked or removed. PHPStan can be run with ```terminal Build/Scripts/runTests.sh -s phpstan ``` Generate baseline with ```terminal Build/Scripts/runTests.sh -s phpstanBaseline ``` (cherry picked from commit 8661cfc)
linawolf
added a commit
that referenced
this pull request
May 4, 2024
The TYPO3 Core and the Best Practice Team recommends to have a static code analyzer in the defense line, and preferes PHPStan due to experience with that tool. This change now adds the static code analyser `PHPStan` with a first configurattion and a lower level as a start. Levels can be raised step by step in follow-ups. Note: XClass `Classes/Xclass/NewRecordController.php` example does not work anymore, most likely since v12. Added a comment to emphasize this, and that it should be reworked or removed. PHPStan can be run with ```terminal Build/Scripts/runTests.sh -s phpstan ``` Generate baseline with ```terminal Build/Scripts/runTests.sh -s phpstanBaseline ``` (cherry picked from commit 8661cfc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TYPO3 Core and the Best Practice Team recommends
to have a static code analyzer in the defense line,
and preferes PHPStan due to experience with that tool.
This change now adds the static code analyser
PHPStanwith a first configurattion and a lower level as a start.
Levels can be raised step by step in follow-ups.
Note: XClass
Classes/Xclass/NewRecordController.phpexample does not work anymore, most likely since v12.
Added a comment to emphasize this, and that it should
be reworked or removed.
PHPStan can be run with
Generate baseline with