Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json fields #14

Closed
schloram opened this issue Aug 21, 2019 · 2 comments
Closed

Add json fields #14

schloram opened this issue Aug 21, 2019 · 2 comments
Labels
good first issue Good for newcomers

Comments

@schloram
Copy link
Contributor

Hi,
there are some fields that are missing in my opinion.

In "lib.page":

  • files (array of objects): The files added to a page in "Resources -> Files"
  • socialMedia (object): The fields og_title, og_description, twitter_title, twitter_description, twitter_image combined.
  • noSearch (bool): The output of the field "Include in Search"
  • categories (array of objects): The categories the page is assigned to.

In "lib.contentElement":

  • categories (array of objects): The categories the content element is assigned to.

Is there a reason that these fields are missing or do you think they can be added as well? Because I think they are important for the frontend rendering.

@lukaszuznanski
Copy link
Collaborator

Hi,
yes, those fields should be added. There is no extra reason, we just forgot about them, as we don't use them atm.

@schloram
Copy link
Contributor Author

Thanks for your super fast response. :)

I will add them in a PR soon.

best,
R

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
No open projects
Development

No branches or pull requests

2 participants