Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

YouTubeRenderer and PHP 8.1 #502

Closed
AKaravas opened this issue Oct 31, 2022 · 0 comments · Fixed by #503
Closed

YouTubeRenderer and PHP 8.1 #502

AKaravas opened this issue Oct 31, 2022 · 0 comments · Fixed by #503
Assignees
@twoldanski
Labels
bug Something isn't working

Comments

@AKaravas
Copy link

AKaravas commented Oct 31, 2022 •
edited
Loading

I used the sys_file_reference with TYPO3 11 and PHP 8.1 to add a YouTube Video in the website and i go the following error.

PHP Warning: Undefined array key "controls" in /typo3/sysext/core/Classes/Resource/Rendering/YouTubeRenderer.php line 142

At first i thought it was a core problem but after a discussion on the typo3-cms Channel in Slack, it looks like that the headless Custom YouTubeRenderer is not properly implemented. Hier is the discussion that might help solving the problem

Screenshot 2022-10-31 at 10 27 50

Screenshot 2022-10-31 at 10 28 10

Until this is fixed, we can not update to PHP 8.1 and the support for PHP 7.4 is coming to an end.
twoldanski added a commit that referenced this issue Nov 2, 2022
@twoldanski
[BUGFIX] fix warnings tag renderers
b6f0d91 
- remove dead code
- fix warnings on PHP 8.1
- resolves #502
@twoldanski twoldanski mentioned this issue Nov 2, 2022
Merged
twoldanski added a commit that referenced this issue Nov 2, 2022
@twoldanski
[BUGFIX] fix warnings tag renderers
fdfe3a5 
- remove dead code
- fix warnings on PHP 8.1
- resolves #502
lukaszuznanski pushed a commit that referenced this issue Nov 2, 2022
@twoldanski
[BUGFIX] fix warnings tag renderers (#503)
e905ac6 
- remove dead code
- fix warnings on PHP 8.1
- resolves #502
@lukaszuznanski lukaszuznanski added the bug Something isn't working label Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@twoldanski twoldanski

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[BUGFIX] fix warnings tag renderers TYPO3-Headless/headless
3 participants
@lukaszuznanski @AKaravas @twoldanski