Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Fallback of solr_core_read does not work #3362

Closed
christophlehmann opened this issue Oct 18, 2022 · 2 comments · Fixed by #3363
Closed

[BUG] Fallback of solr_core_read does not work #3362

christophlehmann opened this issue Oct 18, 2022 · 2 comments · Fixed by #3363

Comments

@christophlehmann
Copy link
Contributor

Describe the bug

This is about an empty solr_core_read in a site language.

As per default (last parameter in line 293 = true) a site language will be indexed, whether or not solr_core_read is empty.

Bildschirmfoto 2022-10-18 um 11 50 53

In Line 306 core_en should be the default (fallback) core, if non given (=null value). But i couldn't be null, since its a string field and is might be just empty.

An empty string leads to a wrong path and indexing fails.

Expected behavior

It could be more explizit: When a core is given and not empty, then index that language, else not.

We can see it also as a feature, so that one can deactivate indexing a language with an empty solr_core_read property.

Used versions (please complete the following information):

  • TYPO3 Version: ^11
  • EXT:solr Version: ^11
christophlehmann pushed a commit to christophlehmann/ext-solr that referenced this issue Oct 18, 2022
[TASK] Do not index language with unconfigured core
a3f982a 
Relates: TYPO3-Solr#3362
christophlehmann pushed a commit to christophlehmann/ext-solr that referenced this issue Oct 18, 2022
[TASK] Do not index language with unconfigured core
e8c46e8 
Relates: TYPO3-Solr#3362
@christophlehmann
Copy link
Contributor Author

@dkd-kaehm If the fix is fine for your, then i would go on with fixing the tests and extending the docs

@dkd-kaehm
Copy link
Collaborator

@christophlehmann
LGTM, please open a pull request with this changes to start the tests.

@christophlehmann christophlehmann mentioned this issue Oct 19, 2022
Merged
dkd-kaehm pushed a commit to dkd-kaehm/ext-solr that referenced this issue Oct 21, 2022
@dkd-kaehm
[TASK:BP:11.5] Do not index language with unconfigured core
db7664e 
Relates: TYPO3-Solr#3362
Ports: TYPO3-Solr#3363
dkd-kaehm pushed a commit to dkd-kaehm/ext-solr that referenced this issue Oct 21, 2022
@dkd-kaehm
[TASK:BP:11.5] Do not index language with unconfigured core
d049abf 
It disables indexing a language that has no core configured.

Further there are no connection errors in the backend module nor pages with indexing errors due to that language

Relates: TYPO3-Solr#3362
Ports: TYPO3-Solr#3363
@dkd-kaehm dkd-kaehm mentioned this issue Oct 21, 2022
Merged
dkd-kaehm pushed a commit that referenced this issue Oct 21, 2022
@dkd-kaehm
[TASK] Do not index language with unconfigured core
3b1258b 
Relates: #3362
dkd-kaehm pushed a commit that referenced this issue Oct 21, 2022
@dkd-kaehm
[TASK:BP:11.5] Do not index language with unconfigured core
a3ade2a 
It disables indexing a language that has no core configured.

Further there are no connection errors in the backend module nor pages with indexing errors due to that language

Relates: #3362
Ports: #3363
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[TASK] Do not index language with unconfigured core christophlehmann/ext-solr
2 participants
@christophlehmann @dkd-kaehm