Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Use PSR-14 events instead of hooks in IndexQueue #3666

Closed
Tracked by #3376
bmack opened this issue Jun 2, 2023 · 0 comments · Fixed by #3667
Closed
Tracked by #3376

[FEATURE] Use PSR-14 events instead of hooks in IndexQueue #3666

bmack opened this issue Jun 2, 2023 · 0 comments · Fixed by #3667

Comments

@bmack
Copy link
Collaborator

bmack commented Jun 2, 2023

There are several old solutions for the hooks, however TYPO3 v10 already has the PSR-14 event support.

We should migrate them in the IndexQueue section.
bmack added a commit to bmack/ext-solr that referenced this issue Jun 2, 2023
@bmack
[!!!][TASK] Migrate IndexQueue hooks to PSR-14 events
2f4ebe2 
More hooks have been removed:

The hook :php:`$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['postProcessIndexQueueInitialization']` and its
interface :php:`ApacheSolrForTypo3\Solr\IndexQueue\InitializationPostProcessor` are now superseded
by the PSR-14 event :php:`ApacheSolrForTypo3\Solr\Event\IndexQueue\AfterIndexQueueHasBeenInitializedEvent`

The hook :php:`$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['postProcessFetchRecordsForIndexQueueItem']` is now superseded
by the PSR-14 event :php:`ApacheSolrForTypo3\Solr\Event\IndexQueue\AfterRecordsForIndexQueueItemsHaveBeenRetrievedEvent`

Fixes: TYPO3-Solr#3666
@bmack bmack mentioned this issue Jun 2, 2023
Merged
bmack added a commit to bmack/ext-solr that referenced this issue Jun 2, 2023
@bmack
[!!!][FEATURE] Migrate IndexQueue hooks to PSR-14 events
291c5d3 
More hooks have been removed:

The hook :php:`$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['postProcessIndexQueueInitialization']` and its
interface :php:`ApacheSolrForTypo3\Solr\IndexQueue\InitializationPostProcessor` are now superseded
by the PSR-14 event :php:`ApacheSolrForTypo3\Solr\Event\IndexQueue\AfterIndexQueueHasBeenInitializedEvent`

The hook :php:`$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['postProcessFetchRecordsForIndexQueueItem']` is now superseded
by the PSR-14 event :php:`ApacheSolrForTypo3\Solr\Event\IndexQueue\AfterRecordsForIndexQueueItemsHaveBeenRetrievedEvent`

Tests have been added and documentation has been adapted.

Fixes: TYPO3-Solr#3666
dkd-kaehm pushed a commit that referenced this issue Jun 2, 2023
@bmack @dkd-kaehm
[!!!][FEATURE] Migrate IndexQueue hooks to PSR-14 events
17f46ce 
More hooks have been removed:

The hook :php:`$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['postProcessIndexQueueInitialization']` and its
interface :php:`ApacheSolrForTypo3\Solr\IndexQueue\InitializationPostProcessor` are now superseded
by the PSR-14 event :php:`ApacheSolrForTypo3\Solr\Event\IndexQueue\AfterIndexQueueHasBeenInitializedEvent`

The hook :php:`$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['postProcessFetchRecordsForIndexQueueItem']` is now superseded
by the PSR-14 event :php:`ApacheSolrForTypo3\Solr\Event\IndexQueue\AfterRecordsForIndexQueueItemsHaveBeenRetrievedEvent`

Tests have been added and documentation has been adapted.

Fixes: #3666
sfroemkenjw pushed a commit to sfroemkenjw/ext-solr that referenced this issue Jun 2, 2023
@bmack @sfroemkenjw
[!!!][FEATURE] Migrate IndexQueue hooks to PSR-14 events
a0e2ba7 
More hooks have been removed:

The hook :php:`$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['postProcessIndexQueueInitialization']` and its
interface :php:`ApacheSolrForTypo3\Solr\IndexQueue\InitializationPostProcessor` are now superseded
by the PSR-14 event :php:`ApacheSolrForTypo3\Solr\Event\IndexQueue\AfterIndexQueueHasBeenInitializedEvent`

The hook :php:`$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['postProcessFetchRecordsForIndexQueueItem']` is now superseded
by the PSR-14 event :php:`ApacheSolrForTypo3\Solr\Event\IndexQueue\AfterRecordsForIndexQueueItemsHaveBeenRetrievedEvent`

Tests have been added and documentation has been adapted.

Fixes: TYPO3-Solr#3666
bmack added a commit to bmack/ext-solr that referenced this issue Jun 2, 2023
@bmack
[!!!][FEATURE] Migrate Index Queue Hook to PSR-14 event
09006bd 
The hook `$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['postProcessIndexQueueUpdateItem']`
is now migrated to a new PSR-14 event
`ApacheSolrForTypo3\Solr\Event\IndexQueue\AfterIndexQueueItemHasBeenMarkedForReindexingEvent`

Documentation is updated.

Relates: TYPO3-Solr#3666
@bmack bmack mentioned this issue Jun 2, 2023
Merged
@dkd-kaehm dkd-kaehm mentioned this issue Jun 2, 2023
Closed
68 tasks
dkd-kaehm pushed a commit that referenced this issue Jun 5, 2023
@bmack @dkd-kaehm
[!!!][FEATURE] Migrate Index Queue Hook to PSR-14 event
6a75678 
The hook `$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['postProcessIndexQueueUpdateItem']`
is now migrated to a new PSR-14 event
`ApacheSolrForTypo3\Solr\Event\IndexQueue\AfterIndexQueueItemHasBeenMarkedForReindexingEvent`

Documentation is updated.

Relates: #3666
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[!!!][TASK] Migrate IndexQueue hooks to PSR-14 events bmack/ext-solr
1 participant
@bmack