Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[!!!][TASK] Use solarium as http client #2070

Conversation

timohund
Copy link
Contributor

@timohund timohund commented Aug 7, 2018

In #2067 we use the php solarium api, where we can to build queries with solarium.

The next step is to use the solarium api to perform the http requests to the solr server. Then we can drop the old SolrPhpClient code.

This pr:

  • Uses the solarium client where possible to perform requests to the solr server.
  • In the case where it is not possible, because this feature is not yet supported in solarium, we peform the http requests with the Adapters that are shipped with solarium. By default we use guzzle, since this is also shipped with TYPO3 and the preferred way
  • The parts in the code that previously return and \Apache_Solr_Response now return a \ApacheSolrForTypo3\Solr\System\Solr\ResponseAdapter this response adapter behaves like the previous \Apache_Solr_Response, to keep the code more backwards compatible. In a later step we could make the new Solarium domain objects available with that adapter to allow a step-by-step refactoring

What is missing:

  • By now we do not use the domain objects (Result, Facet, ...) from solarium since this would require more breaking changes evenen in the templates. But in the future we plan to use as much as possible from the solarium api to have a bigger benefit from the ongoing deveopment of solarium.

@timohund timohund force-pushed the task/master/1778-use-solarium-as-http-client branch 11 times, most recently from 044df49 to 60a4f68 Compare August 10, 2018 09:59
@timohund timohund force-pushed the task/master/1778-use-solarium-as-http-client branch from 60a4f68 to c388bb1 Compare August 10, 2018 10:43
@timohund timohund merged commit 17ae056 into TYPO3-Solr:master Aug 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant