[BUGFIX:BP:11.5] Fix Solr response handling during indexing #3544
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkd-friedrich
force-pushed
the
bugfix/release-11.5.x/3108-fix_solr_response_handling
branch
from
4c4d5c9
to
40ad1f6
Compare
If a Solr response is not valid (=200) the index queue item should be marked as failed to prevent the indexer of being blocked. This commit fixes this issue by throwing an IndexingException which causes the IndexService to mark the item as failed. Resolves: TYPO3-Solr#3108
dkd-friedrich
force-pushed
the
bugfix/release-11.5.x/3108-fix_solr_response_handling
branch
from
40ad1f6
to
b1ab80e
Compare
dkd-friedrich
changed the title
dkd-friedrich
merged commit 372a925
into
TYPO3-Solr:release-11.5.x
8 of 9 checks passed
dkd-friedrich
deleted the
bugfix/release-11.5.x/3108-fix_solr_response_handling
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
If a Solr response is not valid (=200) the index queue item should be marked as failed to prevent the indexer of being blocked. This commit fixes this issue by throwing an
IndexingExceptionwhich causes theIndexServiceto mark the item as failed.How to test
Queue items should now be marked as failed and the indexing should not fail silently.
Resolves: #3108