[!!!][TASK] Remove deprecated functionality #3585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea to remove the deprecated functions, but I see further steps that are necessary in this process:
@bmack Do you have time for the adaptions or should I take care of this? |
dkd-kaehm
force-pushed
the
task/3376-TYPO3_12_compatibility
branch
2 times, most recently
from
b846714
to
6cffa97
Compare
dkd-kaehm
force-pushed
the
task/3376-TYPO3_12_compatibility
branch
from
e7e2e9d
to
e9e7248
Compare
This was referenced May 15, 2023
dkd-kaehm
force-pushed
the
deprecated-code-v12
branch
2 times, most recently
from
e2f77ba
to
2fb69cc
Compare
This change removes deprecated features of EXT:solr a) PageDocumentPostProcessor The interface PageDocumentPostProcessor is removed, along with the registration in ext_localconf.php. The PostProcessor is now removed in favor of the PageIndexerDocumentsModifier interface, and can be used already in EXT:solr v11. Check in your extensions' ext_localconf.php and look for `$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPagePostProcessPageDocument']` to see if you are affected. In addition, some rather unintrusive, deprecated methods in UrlHelper have been removed as UrlHelper is just a small extension for UriInterface, and might vanish altogether in the future. Relates: TYPO3-Solr#3376
bmack
force-pushed
the
deprecated-code-v12
branch
from
2fb69cc
to
41130b3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this pr does
This change removes deprecated features of EXT:solr
a) PageDocumentPostProcessor
The interface PageDocumentPostProcessor
is removed, along with the registration
in ext_localconf.php.
The PostProcessor is now removed in favor
of the PageIndexerDocumentsModifier interface,
and can be used already in EXT:solr v11.
Check in your extensions' ext_localconf.php
and look for
$GLOBALS['TYPO3_CONF_VARS']['EXTCONF']['solr']['Indexer']['indexPagePostProcessPageDocument']to see if you are affected.b) UrlHelper methods
In addition, some rather unintrusive, deprecated
methods in UrlHelper have been removed
as UrlHelper is just a small
extension for UriInterface, and might
vanish altogether in the future.
Relates: #3376
Todo: