[!!!][TASK] Rework frontend indexing helpers #3674
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkd-kaehm
approved these changes
Jun 5, 2023
This change cleans up a few parts within the FrontendHelper logic when indexing a page in the frontend: - The PageIndexerInitialization and PageIndexerFinisher middleware are now merged. - The PageIndexerRequestHandler contains no state - The PageIndexerRequest is added to the PSR-7 Request as attribute "solr.pageIndexingInstructions" so it can be retrieved in various places. - The AbstractFrontendHelper is removed, as the FrontendHelper middleware is thinned out. Activation and Deactivation rather works as initialization and flushing This allows us to use DI in various places we hadn't had a chance before. In addition, the AuthorizationService getGroupsFE is removed as it has been already replaced by a PSR-14 event.
AuthorizationService is now registered at any time and now listens properly to the request object.
68 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change cleans up a few parts within the FrontendHelper logic when indexing a page in the frontend:
The PageIndexerInitialization and PageIndexerFinisher middleware are now merged.
The PageIndexerRequestHandler contains no state
The PageIndexerRequest is added to the PSR-7 Request as attribute "solr.pageIndexingInstructions" so it can be retrieved in various places.
The AbstractFrontendHelper is removed, as the FrontendHelper middleware is thinned out. Activation and Deactivation rather works as initialization and flushing
This allows us to use DI in various places we hadn't had a chance before.
In addition, the AuthorizationService getGroupsFE is removed as it has been already replaced by a PSR-14 event.