[BUGFIX] Provide proper Uri Builder Request in VH #3852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@DanielSiepmann |
DanielSiepmann
force-pushed
the
3851-proper-uri-builder-request
branch
from
06f0179
to
a8ebfb6
Compare
DanielSiepmann
commented
Oct 30, 2023
Checking RenderingContext is not enough as it might provide either a ServerRequest or Extbase Request. We use the RequestBuilder to ensure there is a proper Extbase Request. A none Extbase Request might exist in case of usage within StandaloneView or other contexts without providing an Extbase Request. Fixes: #3851
DanielSiepmann
force-pushed
the
3851-proper-uri-builder-request
branch
from
a8ebfb6
to
b2f99cf
Compare
dkd-kaehm
approved these changes
Oct 31, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checking RenderingContext is not enough as it might provide either a ServerRequest or Extbase Request.
We use the RequestBuilder to ensure there is a proper Extbase Request.
A none Extbase Request might exist in case of usage within StandaloneView or other contexts without providing an Extbase Request.
Fixes: #3851
What this pr does
Ensure that an Extbase request is provided.
How to test
I don't have an easy step by step way … Maybe test that this won't break anything instead?