[BUGFIX] Have index updated when using frontend editing #648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irnnr
suggested changes
Sep 14, 2016
| @@ -132,7 +132,8 @@ | |||
| 'solr::clearSolrConnectionCache', | |||
| 'ApacheSolrForTypo3\\Solr\\ConnectionManager->updateConnections' | |||
| ); | |||
|
|
|||
| } | |||
| if ((TYPO3_MODE == 'BE') || ((TYPO3_MODE == 'FE') && isset($_POST['TSFE_EDIT']))) { | |||
There was a problem hiding this comment.
Can you make two changes here:
- You don't need the braces around
TYPO3_MODE == 'FE' - Please use triple equal signs for comparison
===
irnnr
reviewed
Sep 14, 2016
|
cHash generation has changed with latest TYPO3 release for new installations and now takes id into calculation. See: https://typo3.org/teams/security/security-bulletins/typo3-core/typo3-core-sa-2016-022/ |
|
ah right, thanks @stmllr |
|
I've fixed the broken tests that are related to the cHash change. Tests are running through now and since everything else looks good, i'll merge this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DataHandler (TceMain) hooks are registered also in frontend mode when the TSFE_EDIT post parameter array is present.
Fixes: #647