[BUGFIX] Fix extension installation with fixed key #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The download location for extension packages can be something like ".../vendor/composer/a205122c/" which does not match the extension key, thus use the first item within $EM_CONF instead and be independent from $_EXTKEY.
|
There is only one chance to get this in from my PoV and that is changing the parsing code in every location it exists to do exactly what you propose here. until this happens, I'm closing the PR here. |
|
OK, totally get that, this needs to be changed in TYPO3 itself first. |
mbrodala
added a commit
to pagemachine/hairu
that referenced
this pull request
Jan 13, 2017
The only way to more or less reliably change that is to create a lib that parses ext_emconf and use it everywhere. On top, we must start throwing exception (disallowing TER upload) on parsing errors of this lib. This is a lot of effort for changing a format that is dated and for the reason people started ignoring a pretty strict requirement of that format. |
|
See #60 for more descriptive errors. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The download location for extension packages can be something like ".../vendor/composer/a205122c/" which does not match the extension key, thus use the first item within $EM_CONF instead and be independent from $_EXTKEY.