[TASK] Remove CreatePackageStatesTask

Migrate: Please add "@php vendor/bin/typo3cms install:generatepackagestates" in your root composer.json file in the post-autoload-dump scripts section.
TYPO3 · Apr 18, 2020 · c197f6d · c197f6d
1 parent 664148f
commit c197f6d
Show file tree

Hide file tree

Showing 6 changed files with 4 additions and 70 deletions.
diff --git a/Documentation/DeploymentFlow/Index.rst b/Documentation/DeploymentFlow/Index.rst
@@ -82,10 +82,10 @@ If you like to add your own tasks to a specific stage of the flow, you can just
     $workflow->beforeStage('YourTask', 'cleanup');
 
    // Add tasks that shall be executed before the given task
-   $workflow->beforeTask(CreatePackageStatesTask::class, 'YourTask');
+   $workflow->beforeTask(AnotherTask::class, 'YourTask');
 
    // Add tasks that shall be executed after the given task
-   $workflow->afterTask(CreatePackageStatesTask::class, 'YourTask');
+   $workflow->afterTask(AnotherTask::class, 'YourTask');
 
 If you like to remove certain tasks from the flow, just do it like that::
 

diff --git a/Documentation/Examples/TYPO3/Index.rst b/Documentation/Examples/TYPO3/Index.rst
@@ -41,9 +41,6 @@ If you would like to deploy a TYPO3 Website a good starting point is to use TYPO
                $deployment->getWorkflow()
                    ->beforeTask(\TYPO3\Surf\Task\TYPO3\CMS\SetUpExtensionsTask::class, \TYPO3\Surf\Task\TYPO3\CMS\CompareDatabaseTask::class, $application)
                    ->beforeStage('transfer', \TYPO3\Surf\Task\Php\WebOpcacheResetCreateScriptTask::class, $application)
-                   ->afterStage('switch', \TYPO3\Surf\Task\Php\WebOpcacheResetExecuteTask::class, $application)
-                   // CreatePackageStatesTask is done by post-autoload-dump script and can be removed
-                   // https://github.com/TYPO3/TYPO3.CMS.BaseDistribution/blob/9.x/composer.json#L38
-                   ->removeTask(\TYPO3\Surf\Task\TYPO3\CMS\CreatePackageStatesTask::class, $application);
+                   ->afterStage('switch', \TYPO3\Surf\Task\Php\WebOpcacheResetExecuteTask::class, $application);
            }
        );
diff --git a/Documentation/Tasks/Index.rst b/Documentation/Tasks/Index.rst
@@ -120,7 +120,7 @@ Besides specifying the execution point via a stage, you can also give an existin
 
     ...
 
-    $workflow->beforeTask(CreatePackageStatesTask::class,
+    $workflow->beforeTask(SomeTask::class,
         [
             'CopyEnvFileTask'
         ]

diff --git a/src/Application/TYPO3/CMS.php b/src/Application/TYPO3/CMS.php
@@ -13,7 +13,6 @@
 use TYPO3\Surf\Domain\Model\Workflow;
 use TYPO3\Surf\Task\DumpDatabaseTask;
 use TYPO3\Surf\Task\RsyncFoldersTask;
-use TYPO3\Surf\Task\TYPO3\CMS\CreatePackageStatesTask;
 use TYPO3\Surf\Task\TYPO3\CMS\FlushCachesTask;
 use TYPO3\Surf\Task\TYPO3\CMS\SetUpExtensionsTask;
 use TYPO3\Surf\Task\TYPO3\CMS\SymlinkDataTask;
@@ -60,7 +59,6 @@ public function registerTasks(Workflow $workflow, Deployment $deployment): void
             $workflow->addTask(RsyncFoldersTask::class, 'initialize', $this);
         }
         $workflow
-            ->afterStage('transfer', CreatePackageStatesTask::class, $this)
             ->afterStage('update', SymlinkDataTask::class, $this)
             ->afterStage('switch', FlushCachesTask::class, $this)
             ->addTask(SetUpExtensionsTask::class, 'migrate', $this);

diff --git a/src/Task/TYPO3/CMS/CreatePackageStatesTask.php b/src/Task/TYPO3/CMS/CreatePackageStatesTask.php
diff --git a/tests/Unit/Command/DescribeCommandTest.php b/tests/Unit/Command/DescribeCommandTest.php
@@ -257,7 +257,6 @@ public function describeTypo3Cms(): void
           <success>TYPO3\Surf\Task\Transfer\RsyncTask</success> (for application TYPO3 CMS)
         after:
           <success>TYPO3\Surf\Task\Generic\CreateSymlinksTask</success> (for application TYPO3 CMS)
-          <success>TYPO3\Surf\Task\TYPO3\CMS\CreatePackageStatesTask</success> (for application TYPO3 CMS)
       update:
         after:
           <success>TYPO3\Surf\Task\TYPO3\CMS\SymlinkDataTask</success> (for application TYPO3 CMS)